677330 - Stop spam from Selenium tests (review notifications)

Status: RESOLVED INCOMPLETE

(addons.mozilla.org Graveyard :: Developer Pages, defect)

Description

[Wladimir Palant]

I get mails like this one regularly:

> A user has left a review for your add-on, Adblock Plus.
> 
> Rating:
> *
> 
> Review:
> Automatic addon review by Selenium tests
> 
> You can read the review and reply to it here:
> https://addons.allizom.org/addon/adblock-plus/reviews/295175/reply

Is it really necessary to send notifications about "reviews" added on addons.allizom.org? And if it is, is it possible to use a test add-on for Selenium tests rather than mine?

Comment 1

[Gregory Koberger (:gkoberger)]

Sorry about that, Wladimir.  I didn't realize Selenium was using real add-ons for their tests.  I'll get it fixed ASAP.

Comment 2

[Gregory Koberger (:gkoberger)]

https://github.com/gkoberger/zamboni/commit/5ebd152
https://github.com/gkoberger/zamboni/commit/79c4f16

QA can now view emails in Admin > Manage Add-ons > Fake Mail
https://addons.allizom.org/z/en-US/admin/mail

Thanks, Wladimir :) Sorry for the spam!

Comment 3

[krupa raj[:krupa]]

emails on preview are being logged now.

Comment 4

[Wladimir Palant]

Last spam was seven hours ago, before that they were arriving hourly - so I guess that I can also verify it as fixed.

Comment 5

[Wladimir Palant]

Reopening - I just got this review: https://addons.mozilla.org/en-US/firefox/addon/adblock-plus/reviews/325780/. That's the production site!

Comment 6

[Marlena Compton [:marlenac]]

I've disabled the production build of the selenium tests until we can look into this and make sure it doesn't happen again.