Last Comment Bug 677370 - Fixup Android configure.in bits
: Fixup Android configure.in bits
Status: RESOLVED FIXED
:
Product: Core
Classification: Components
Component: Build Config (show other bugs)
: Trunk
: ARM Android
: -- normal (vote)
: mozilla8
Assigned To: Nobody; OK to take it and work on it
:
Mentors:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2011-08-08 14:39 PDT by Mike Hommey [:glandium]
Modified: 2011-08-09 11:49 PDT (History)
1 user (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
Fixup Android configure.in bits. (3.85 KB, patch)
2011-08-08 14:40 PDT, Mike Hommey [:glandium]
mh+mozilla: review+
Details | Diff | Review

Description Mike Hommey [:glandium] 2011-08-08 14:39:24 PDT
A few bits in configure.in are broken:
- Setting of the ANDROID_TOOLCHAIN and ANDROID_PLATFORM variables
- The use of -static-libstdc++ which is only supported on gcc >= 4.5. (added for bug 674910, but in the end, wrong)

Bug 674910 contains a reviewed patch addressing both of the above and another part that I'm going to strip off.
Comment 1 Mike Hommey [:glandium] 2011-08-08 14:40:58 PDT
Created attachment 551575 [details] [diff] [review]
Fixup Android configure.in bits.
Comment 2 Mike Hommey [:glandium] 2011-08-08 14:42:45 PDT
Comment on attachment 551575 [details] [diff] [review]
Fixup Android configure.in bits.

Carrying out blassey's r+ from bug 674910
Comment 4 :Ehsan Akhgari (busy, don't ask for review please) 2011-08-09 11:49:52 PDT
http://hg.mozilla.org/mozilla-central/rev/1b052a519dd9

Note You need to log in before you can comment on or make changes to this bug.