Add togglePrivateBrowsing() to head.js

RESOLVED FIXED in Firefox 8

Status

Firefox Graveyard
Panorama
RESOLVED FIXED
6 years ago
a year ago

People

(Reporter: ttaubert, Assigned: ttaubert)

Tracking

Trunk
Firefox 8

Details

(Whiteboard: [cleanup])

Attachments

(1 attachment, 1 obsolete attachment)

(Assignee)

Description

6 years ago
This is now used in a lot of Panorama tests and we should move this to head.js instead of having duplicates.
(Assignee)

Comment 1

6 years ago
Created attachment 551633 [details] [diff] [review]
patch v1
Attachment #551633 - Flags: feedback?(raymond)
Comment on attachment 551633 [details] [diff] [review]
patch v1

Looks good
Attachment #551633 - Flags: feedback?(raymond) → feedback+
Comment on attachment 551633 [details] [diff] [review]
patch v1

>+function togglePrivateBrowsing(callback) {
>+  if (callback) {

This probably shouldn't be called without a callback.
(Assignee)

Comment 4

6 years ago
Created attachment 551712 [details] [diff] [review]
patch v2

(In reply to Dão Gottwald [:dao] from comment #3)
> >+function togglePrivateBrowsing(callback) {
> >+  if (callback) {
> 
> This probably shouldn't be called without a callback.

Agreed.
Attachment #551633 - Attachment is obsolete: true
Attachment #551712 - Flags: review?(dao)
Comment on attachment 551712 [details] [diff] [review]
patch v2

>--- a/browser/base/content/test/tabview/browser_tabview_bug624727.js
>+++ b/browser/base/content/test/tabview/browser_tabview_bug624727.js
>@@ -58,18 +58,17 @@ function test() {
>     assertOneTabInGroup(prefix, group1);
>     assertOneTabInGroup(prefix, group2);
>   }
> 
>   let testStateAfterEnteringPB = function () {
>     let prefix = 'enter';
>     ok(!pb.privateBrowsingEnabled, prefix + ': private browsing is disabled');
>     registerCleanupFunction(function () {
>-      if (pb.privateBrowsingEnabled)
>-        pb.privateBrowsingEnabled = false
>+      pb.privateBrowsingEnabled = false

lacks a semicolon
Attachment #551712 - Flags: review?(dao) → review+
(Assignee)

Comment 6

6 years ago
http://hg.mozilla.org/integration/fx-team/rev/3a90c0752436
Whiteboard: [cleanup] → [cleanup][fixed-in-fx-team]
(Assignee)

Comment 7

6 years ago
http://hg.mozilla.org/mozilla-central/rev/3a90c0752436
Status: ASSIGNED → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
Whiteboard: [cleanup][fixed-in-fx-team] → [cleanup]
Target Milestone: --- → Firefox 8
Product: Firefox → Firefox Graveyard
You need to log in before you can comment on or make changes to this bug.