Last Comment Bug 677423 - Add togglePrivateBrowsing() to head.js
: Add togglePrivateBrowsing() to head.js
Status: RESOLVED FIXED
[cleanup]
:
Product: Firefox Graveyard
Classification: Graveyard
Component: Panorama (show other bugs)
: Trunk
: All All
: -- normal
: Firefox 8
Assigned To: Tim Taubert [:ttaubert]
:
Mentors:
Depends on:
Blocks: 677310
  Show dependency treegraph
 
Reported: 2011-08-08 17:10 PDT by Tim Taubert [:ttaubert]
Modified: 2016-04-12 14:00 PDT (History)
0 users
See Also:
QA Whiteboard:
Iteration: ---
Points: ---


Attachments
patch v1 (7.47 KB, patch)
2011-08-08 17:20 PDT, Tim Taubert [:ttaubert]
raymond: feedback+
Details | Diff | Splinter Review
patch v2 (7.44 KB, patch)
2011-08-09 03:30 PDT, Tim Taubert [:ttaubert]
dao+bmo: review+
Details | Diff | Splinter Review

Description Tim Taubert [:ttaubert] 2011-08-08 17:10:27 PDT
This is now used in a lot of Panorama tests and we should move this to head.js instead of having duplicates.
Comment 1 Tim Taubert [:ttaubert] 2011-08-08 17:20:14 PDT
Created attachment 551633 [details] [diff] [review]
patch v1
Comment 2 Raymond Lee [:raymondlee] 2011-08-08 19:13:56 PDT
Comment on attachment 551633 [details] [diff] [review]
patch v1

Looks good
Comment 3 Dão Gottwald [:dao] 2011-08-09 02:11:32 PDT
Comment on attachment 551633 [details] [diff] [review]
patch v1

>+function togglePrivateBrowsing(callback) {
>+  if (callback) {

This probably shouldn't be called without a callback.
Comment 4 Tim Taubert [:ttaubert] 2011-08-09 03:30:38 PDT
Created attachment 551712 [details] [diff] [review]
patch v2

(In reply to Dão Gottwald [:dao] from comment #3)
> >+function togglePrivateBrowsing(callback) {
> >+  if (callback) {
> 
> This probably shouldn't be called without a callback.

Agreed.
Comment 5 Dão Gottwald [:dao] 2011-08-09 03:34:42 PDT
Comment on attachment 551712 [details] [diff] [review]
patch v2

>--- a/browser/base/content/test/tabview/browser_tabview_bug624727.js
>+++ b/browser/base/content/test/tabview/browser_tabview_bug624727.js
>@@ -58,18 +58,17 @@ function test() {
>     assertOneTabInGroup(prefix, group1);
>     assertOneTabInGroup(prefix, group2);
>   }
> 
>   let testStateAfterEnteringPB = function () {
>     let prefix = 'enter';
>     ok(!pb.privateBrowsingEnabled, prefix + ': private browsing is disabled');
>     registerCleanupFunction(function () {
>-      if (pb.privateBrowsingEnabled)
>-        pb.privateBrowsingEnabled = false
>+      pb.privateBrowsingEnabled = false

lacks a semicolon
Comment 6 Tim Taubert [:ttaubert] 2011-08-09 10:17:03 PDT
http://hg.mozilla.org/integration/fx-team/rev/3a90c0752436
Comment 7 Tim Taubert [:ttaubert] 2011-08-09 16:37:22 PDT
http://hg.mozilla.org/mozilla-central/rev/3a90c0752436

Note You need to log in before you can comment on or make changes to this bug.