Note: There are a few cases of duplicates in user autocompletion which are being worked on.

Run jit-tests in valgrind automatically if available, in |make check|

RESOLVED FIXED in mozilla8

Status

()

Core
JavaScript Engine
RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: Paul Biggar, Unassigned)

Tracking

unspecified
mozilla8
x86
Mac OS X
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Reporter)

Description

6 years ago
Created attachment 551641 [details] [diff] [review]
unconditionally call with --valgrind

In bug 675283, we want to reenable |make check-valgrind| on buildbot. |make check-valgrind| runs the entire jit-test suite, in the same way as |make check|, with the only difference being that 3 test cases are run in valgrind instead.


Since |make check| is for buildbot anyway, we should just always run this with valgrind.


It would nice to make jit-test always run with valgrind, but it adds 30s to a build that only takes 1m otherwise, so this probably isn't worth it.
Attachment #551641 - Flags: review?(nnethercote)
Attachment #551641 - Flags: review?(nnethercote) → review+
So wouldn't this need a build with --enable-valgrind?
(Reporter)

Comment 2

6 years ago
I think the major feature of --enable-valgrind is turning off valgrind, but |make check| runs on the shell which doesn't use valgrind.
http://hg.mozilla.org/mozilla-central/rev/fc45c3236370
Status: NEW → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla8
You need to log in before you can comment on or make changes to this bug.