Closed Bug 677433 Opened 13 years ago Closed 13 years ago

Run jit-tests in valgrind automatically if available, in |make check|

Categories

(Core :: JavaScript Engine, defect)

x86
macOS
defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla8

People

(Reporter: paul.biggar, Unassigned)

References

Details

Attachments

(1 file)

In bug 675283, we want to reenable |make check-valgrind| on buildbot. |make check-valgrind| runs the entire jit-test suite, in the same way as |make check|, with the only difference being that 3 test cases are run in valgrind instead.


Since |make check| is for buildbot anyway, we should just always run this with valgrind.


It would nice to make jit-test always run with valgrind, but it adds 30s to a build that only takes 1m otherwise, so this probably isn't worth it.
Attachment #551641 - Flags: review?(nnethercote)
Attachment #551641 - Flags: review?(nnethercote) → review+
So wouldn't this need a build with --enable-valgrind?
I think the major feature of --enable-valgrind is turning off valgrind, but |make check| runs on the shell which doesn't use valgrind.
http://hg.mozilla.org/mozilla-central/rev/fc45c3236370
Status: NEW → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla8
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: