Created attachment 551641 [details] [diff] [review] unconditionally call with --valgrind In bug 675283, we want to reenable |make check-valgrind| on buildbot. |make check-valgrind| runs the entire jit-test suite, in the same way as |make check|, with the only difference being that 3 test cases are run in valgrind instead. Since |make check| is for buildbot anyway, we should just always run this with valgrind. It would nice to make jit-test always run with valgrind, but it adds 30s to a build that only takes 1m otherwise, so this probably isn't worth it.
So wouldn't this need a build with --enable-valgrind?
I think the major feature of --enable-valgrind is turning off valgrind, but |make check| runs on the shell which doesn't use valgrind.