Last Comment Bug 677582 - Implement CSS3 text-overflow: <left> <right>
: Implement CSS3 text-overflow: <left> <right>
: css3, dev-doc-complete
Product: Core
Classification: Components
Component: CSS Parsing and Computation (show other bugs)
: Trunk
: All All
-- normal (vote)
: mozilla9
Assigned To: Mats Palmgren (:mats)
: Jet Villegas (:jet)
Depends on: 681489 684266
  Show dependency treegraph
Reported: 2011-08-09 09:57 PDT by Mats Palmgren (:mats)
Modified: 2011-11-09 15:12 PST (History)
11 users (show)
mats: in‑testsuite+
See Also:
Crash Signature:
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---

part 1, style system (11.80 KB, patch)
2011-08-09 10:21 PDT, Mats Palmgren (:mats)
dbaron: review+
Details | Diff | Splinter Review
part 2, layout (5.34 KB, patch)
2011-08-09 10:24 PDT, Mats Palmgren (:mats)
roc: review+
Details | Diff | Splinter Review
part 3, tests (5.05 KB, patch)
2011-08-09 10:26 PDT, Mats Palmgren (:mats)
roc: review+
Details | Diff | Splinter Review

Description User image Mats Palmgren (:mats) 2011-08-09 09:57:52 PDT
Our proposed two-value syntax "text-overflow: <left> <right>" has now
been added to the spec (at risk).  This bug is for resurrecting the
patches from bug 312156 to implement it.
Comment 1 User image Mats Palmgren (:mats) 2011-08-09 10:21:58 PDT
Created attachment 551815 [details] [diff] [review]
part 1, style system

David, I think you have already reviewed this once in bug 312156.
Comment 2 User image Mats Palmgren (:mats) 2011-08-09 10:24:22 PDT
Created attachment 551816 [details] [diff] [review]
part 2, layout

IIRC, this was already reviewed in bug 312156 too, before we took it out.
Comment 3 User image Mats Palmgren (:mats) 2011-08-09 10:26:04 PDT
Created attachment 551817 [details] [diff] [review]
part 3, tests

Reftests testing separate left/right values.
Comment 4 User image David Baron :dbaron: ⌚️UTC-8 2011-08-17 21:14:41 PDT
Comment on attachment 551815 [details] [diff] [review]
part 1, style system

>Bug 677582 - Implement CSS3 text-overflow: <left> <right>.  r=dbaron

Don't use the same commit message for multiple patches.  Including " in 
the style system" before the end of the sentence would suffice in this


>+  // text-overflow: enum, string, pair(enum|string), inherit, initial

It's misleading to list enum, string twice, since they can only be in a

r=dbaron with that
Comment 7 User image j.j. 2011-09-30 21:56:41 PDT
Mats, if I understand things right, spec and implementation will change very soon?
I removed "dev-doc-needed" keyword to avoid wrong documentation. Please re-add here when you reopen this or add it to the new bug.
Comment 8 User image j.j. 2011-10-13 08:46:55 PDT
For MDN docs:
Bug 684266 changed behaviour and will likely land on Mozilla 9.
The relevant and implemented spec is in URL field.
Comment 9 User image Jean-Yves Perrier [:teoli] 2011-10-25 09:44:11 PDT
I've updated .
It would be nice if somebody can do a technical review of it wrt this bug and bug 684266.

Then I'll update Firefox 9 for developers. (and Fx10 for bug 684266)
Comment 10 User image Eric Shepherd [:sheppy] 2011-11-09 15:12:20 PST
I've gone ahead and added it to Firefox 9 for developers; more likely to get a review this way. Also added NeedsTechnicalReview to the page.

Note You need to log in before you can comment on or make changes to this bug.