Implement CSS3 text-overflow: <left> <right>

RESOLVED FIXED in mozilla9

Status

()

Core
CSS Parsing and Computation
RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: Mats Palmgren (vacation - back in August), Assigned: Mats Palmgren (vacation - back in August))

Tracking

({css3, dev-doc-complete})

Trunk
mozilla9
css3, dev-doc-complete
Points:
---
Dependency tree / graph
Bug Flags:
in-testsuite +

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [css3-ui][inbound], URL)

Attachments

(3 attachments)

Our proposed two-value syntax "text-overflow: <left> <right>" has now
been added to the spec (at risk).  This bug is for resurrecting the
patches from bug 312156 to implement it.

http://dev.w3.org/csswg/css3-ui/#text-overflow
Created attachment 551815 [details] [diff] [review]
part 1, style system

David, I think you have already reviewed this once in bug 312156.
Attachment #551815 - Flags: review?(dbaron)
Created attachment 551816 [details] [diff] [review]
part 2, layout

IIRC, this was already reviewed in bug 312156 too, before we took it out.
Attachment #551816 - Flags: review?(roc)
Created attachment 551817 [details] [diff] [review]
part 3, tests

Reftests testing separate left/right values.
Attachment #551817 - Flags: review?(roc)
Attachment #551817 - Flags: review?(roc) → review+
Attachment #551816 - Flags: review?(roc) → review+

Updated

6 years ago
Keywords: dev-doc-needed
Comment on attachment 551815 [details] [diff] [review]
part 1, style system

>Bug 677582 - Implement CSS3 text-overflow: <left> <right>.  r=dbaron

Don't use the same commit message for multiple patches.  Including " in 
the style system" before the end of the sentence would suffice in this
case.


nsRuleNode.cpp:

>+  // text-overflow: enum, string, pair(enum|string), inherit, initial

It's misleading to list enum, string twice, since they can only be in a
pair.

r=dbaron with that
Attachment #551815 - Flags: review?(dbaron) → review+
With nits fixed:
http://hg.mozilla.org/integration/mozilla-inbound/rev/f700f4ef73b9
http://hg.mozilla.org/integration/mozilla-inbound/rev/0f6660f35a46
http://hg.mozilla.org/integration/mozilla-inbound/rev/1e2e4aa817cd
Flags: in-testsuite+
Whiteboard: [css3-ui] → [css3-ui][inbound]
Target Milestone: --- → mozilla9
http://hg.mozilla.org/mozilla-central/rev/f700f4ef73b9
http://hg.mozilla.org/mozilla-central/rev/0f6660f35a46
http://hg.mozilla.org/mozilla-central/rev/1e2e4aa817cd
Status: NEW → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED

Updated

6 years ago
Depends on: 681489

Comment 7

6 years ago
Mats, if I understand things right, spec and implementation will change very soon?
I removed "dev-doc-needed" keyword to avoid wrong documentation. Please re-add here when you reopen this or add it to the new bug.

Updated

6 years ago
Keywords: dev-doc-needed

Comment 8

6 years ago
For MDN docs:
Bug 684266 changed behaviour and will likely land on Mozilla 9.
The relevant and implemented spec is in URL field.
Depends on: 684266
Keywords: dev-doc-needed
I've updated https://developer.mozilla.org/en/CSS/text-overflow .
It would be nice if somebody can do a technical review of it wrt this bug and bug 684266.

Then I'll update Firefox 9 for developers. (and Fx10 for bug 684266)
I've gone ahead and added it to Firefox 9 for developers; more likely to get a review this way. Also added NeedsTechnicalReview to the page.
Keywords: dev-doc-needed → dev-doc-complete
You need to log in before you can comment on or make changes to this bug.