bookmarks.js tries to load container URLs

VERIFIED FIXED in M6

Status

P3
normal
VERIFIED FIXED
20 years ago
3 months ago

People

(Reporter: mozilla, Assigned: slamm)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

(Reporter)

Description

20 years ago
The OpenURL() function in mozilla/rdf/resources/bookmarks.js is wrong; clicking
on a container in the sidebar should never try to open up the URL! Here's a
corrected version of what should be done (with the improper JavaScript commented
out.)

function OpenURL(event,node)
{
/*
  ***** NEVER check against the type! *****

  if (node.getAttribute('type') !=
      "http://home.netscape.com/NC-rdf#Bookmark") {
    return false;
  }
*/

  /* DO check to see whether the item is a container */
  if (node.getAttribute('container') == "true")
  {
    return false;
  }
(Reporter)

Updated

20 years ago
Target Milestone: M6
(Reporter)

Comment 1

20 years ago
I'm setting the target milestone for this to M6 as its a trivial fix.  :^)
(Assignee)

Updated

20 years ago
Status: NEW → ASSIGNED
(Assignee)

Comment 2

20 years ago
I will check it in as soon as I get approval.
(Assignee)

Updated

20 years ago
Status: ASSIGNED → RESOLVED
Last Resolved: 20 years ago
Resolution: --- → FIXED
(Assignee)

Comment 3

20 years ago
Thank you for the fix Robert. I checked it in.
Marking FIXED.

Updated

20 years ago
Status: RESOLVED → VERIFIED

Comment 4

20 years ago
code level fix - i'm marking this verified. if you object, robert, please
reopen...

Updated

3 months ago
Product: Core → Core Graveyard
You need to log in before you can comment on or make changes to this bug.