67767 - Personal Toolbar items shouldn't use HTML colors

Status: RESOLVED WORKSFORME

(SeaMonkey :: Themes, defect, P4)

Description

[Matthew T (active 1999-2002)]

Build: 2001020513, Mac OS 9.0, Classic theme
This probably applies to Windows Classic as well.

To reproduce, option 1:
*   In the `Colors' category of preferences, uncheck `Use system colors'.
*   Set your preferred background color to black, and your text color to the
    lightest shade of gray which the colorpicker will let you choose. Click OK.
*   Look at a folder in the Personal Toolbar.
What you should see:
*   The name of the folder, in the same color as menu titles usually are.
What you actually see:
*   A blank space (unless you look really hard).

To reproduce, option 2:
*   Change your system colors so that chrome background (toolbars, buttons etc)
    is #0000ff (bright blue), or apply an Appearance Manager theme which uses
    that color.
*   Mouse over a bookmark in the Personal Toolbar.
What you should see:
*   The name of the folder, in the normal UI text color.
What you actually see:
*   A blank space.

To reproduce, option 3:
*   Change your system colors so that chrome background (windows, buttons etc)
    is #ff0000 (bright red), or apply an Appearance Manager theme which uses
    that color.
*   Mousedown on a bookmark in the Personal Toolbar.
What you should see:
*   The bookmark text.
What you actually see:
*   A blank space.

There are two problems at work here:
(1) Themes should not use a user's HTML colors at all, because you have no way
    of preventing the HTML colors from clashing with the theme colors.
(2) Classic should not use any colors besides the CSS UI colors, as you have no
    way of preventing those other colors from clashing with the user's chosen
    system colors.

I suggest the following scheme for the Classic skin:
*   On mouseover, bookmarks in the Personal Toolbar should become underlined,
    but should not change color.
*   On mousedown, the text of the bookmarks (and their underline) should change 
    to the color normally used for the background of selected menu items (e.g.
    lavender).

Comment 1

[Joe Hewitt (gone)]

Mass reassigning some of my theme bugs to Shuehan.

Comment 2

[Jeremy M. Dolan]

I think this is FIXED. Chosen colors have no effect on classic or modern's
personal toolbar, at least on Linux. (Even checked "Always use my colors")

Comment 3

[shliang]

giving to andrew

Comment 4

[Andreas Kunz]

Does anybody still see this on Mac?
Also WFM on Win2k.
I think this old bug is dead and should be buried.

Comment 5

[Andreas Kunz]

Unfortunately no answer from anybody...
But from bug 181294 it seems clear where the colors for the PT are set - just
the same way as on Windows.
-> WFM, based on comment #2, the sources and rationality.