Composer: Active edit mode tab should not use hardcoded white color

VERIFIED FIXED in mozilla0.9.6

Status

()

Core
Editor
P4
trivial
VERIFIED FIXED
18 years ago
17 years ago

People

(Reporter: Alexey Semenov, Assigned: shliang)

Tracking

({polish})

Trunk
mozilla0.9.6
polish
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(2 attachments)

1.69 KB, patch
Details | Diff | Splinter Review
1.69 KB, patch
jag (Peter Annema)
: review+
Joe Hewitt (gone)
: superreview+
Details | Diff | Splinter Review
(Reporter)

Description

18 years ago
Now there is hardcoded white color for active editmode tab.
Instead, system color must be used.
You may use "window" color.
Or, and it seems to me it'll be more standard, you may use "ThreeDHighlight" 
for inactive tabs and "ThreeDFace" for active one.

Comment 1

18 years ago
What you mean is Window, ButtonHighlight and ButtonFace

Comment 2

18 years ago
Sorry my bad, ignore my previous post

Updated

18 years ago
Keywords: classic

Updated

18 years ago
Summary: [Classic] Composer: Active edit mode tab should not use hardcoded white color → Composer: Active edit mode tab should not use hardcoded white color

Comment 3

18 years ago
How the hell did this end up in themes? Moving.

Reporter what do you mean by edit mode tab?
Severity: normal → trivial
Component: Themes → Editor
Keywords: classic
(Reporter)

Comment 4

18 years ago
Edit mode tabs are buttons on Edit Mode tooolbar.

Comment 5

18 years ago
Confirmed
Platform: PC
OS: Linux 2.2.17
Mozilla Build: 2001031611

Marking NEW.
Status: UNCONFIRMED → NEW
Ever confirmed: true
Keywords: polish
OS: Windows 2000 → All
Hardware: PC → All

Updated

18 years ago
Status: NEW → ASSIGNED
Priority: -- → P4

Comment 6

17 years ago
Mass reassigning some of my theme bugs to Shuehan.
Assignee: hewitt → shliang
Status: ASSIGNED → NEW
(Assignee)

Updated

17 years ago
Status: NEW → ASSIGNED
Target Milestone: --- → mozilla0.9.6
(Assignee)

Comment 7

17 years ago
Created attachment 52590 [details] [diff] [review]
patch
(Assignee)

Updated

17 years ago
Blocks: 105174
(Assignee)

Comment 8

17 years ago
Created attachment 55320 [details] [diff] [review]
doing this over

Comment 9

17 years ago
Comment on attachment 55320 [details] [diff] [review]
doing this over

r=jag
Attachment #55320 - Flags: review+

Comment 10

17 years ago
Comment on attachment 55320 [details] [diff] [review]
doing this over

sr=hewitt if you change Window to -moz-Window
Attachment #55320 - Flags: superreview+
(Assignee)

Comment 11

17 years ago
checked in
Status: ASSIGNED → RESOLVED
Last Resolved: 17 years ago
Resolution: --- → FIXED

Comment 12

17 years ago
Verified the patch.
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.