Closed Bug 677699 Opened 8 years ago Closed 8 years ago

TiledTextureImage::GetTileRect() computes the wrong offset

Categories

(Core :: Graphics, defect)

ARM
Android
defect
Not set

Tracking

()

RESOLVED FIXED
mozilla8

People

(Reporter: BenWa, Assigned: BenWa)

References

Details

Attachments

(1 file)

No description provided.
Attached patch MoveTo -> MoveBySplinter Review
I don't think this we are hitting this error case but it could be in the future since it assumes that mImages[mCurrentImage]->GetTileRect()'s top left is 0,0 which is not guaranteed.
Attachment #551895 - Flags: review?(florian.haenel)
Comment on attachment 551895 [details] [diff] [review]
MoveTo -> MoveBy

This is only a problem if you're nesting tiled textures, but you're right.
Attachment #551895 - Flags: review?(florian.haenel) → review+
http://hg.mozilla.org/mozilla-central/rev/6e1f4b927575
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Whiteboard: [inbound]
Target Milestone: --- → mozilla8
You need to log in before you can comment on or make changes to this bug.