TiledTextureImage::GetTileRect() computes the wrong offset

RESOLVED FIXED in mozilla8

Status

()

Core
Graphics
RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: BenWa, Assigned: BenWa)

Tracking

Trunk
mozilla8
ARM
Android
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

Comment hidden (empty)
(Assignee)

Comment 1

6 years ago
Created attachment 551895 [details] [diff] [review]
MoveTo -> MoveBy

I don't think this we are hitting this error case but it could be in the future since it assumes that mImages[mCurrentImage]->GetTileRect()'s top left is 0,0 which is not guaranteed.
Attachment #551895 - Flags: review?(florian.haenel)
Comment on attachment 551895 [details] [diff] [review]
MoveTo -> MoveBy

This is only a problem if you're nesting tiled textures, but you're right.
Attachment #551895 - Flags: review?(florian.haenel) → review+
(Assignee)

Comment 3

6 years ago
http://hg.mozilla.org/integration/mozilla-inbound/rev/6e1f4b927575
Whiteboard: [inbound]
http://hg.mozilla.org/mozilla-central/rev/6e1f4b927575
Status: NEW → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
Whiteboard: [inbound]
Target Milestone: --- → mozilla8
You need to log in before you can comment on or make changes to this bug.