Closed
Bug 677699
Opened 13 years ago
Closed 13 years ago
TiledTextureImage::GetTileRect() computes the wrong offset
Categories
(Core :: Graphics, defect)
Tracking
()
RESOLVED
FIXED
mozilla8
People
(Reporter: BenWa, Assigned: BenWa)
References
Details
Attachments
(1 file)
|
927 bytes,
patch
|
heeen
:
review+
|
Details | Diff | Splinter Review |
No description provided.
|
Assignee | |
Comment 1•13 years ago
|
||
I don't think this we are hitting this error case but it could be in the future since it assumes that mImages[mCurrentImage]->GetTileRect()'s top left is 0,0 which is not guaranteed.
Attachment #551895 -
Flags: review?(florian.haenel)
|
||
Comment 2•13 years ago
|
||
Comment on attachment 551895 [details] [diff] [review] MoveTo -> MoveBy This is only a problem if you're nesting tiled textures, but you're right.
Attachment #551895 -
Flags: review?(florian.haenel) → review+
|
|
Assignee | |
Comment 3•13 years ago
|
||
http://hg.mozilla.org/integration/mozilla-inbound/rev/6e1f4b927575
Whiteboard: [inbound]
|
||
Comment 4•13 years ago
|
||
http://hg.mozilla.org/mozilla-central/rev/6e1f4b927575
Status: NEW → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Whiteboard: [inbound]
Target Milestone: --- → mozilla8
You need to log in
before you can comment on or make changes to this bug.
Description
•