67771 - `Use system colors' doesn't take colors from Internet control panel

Status: NEW

(Core :: CSS Parsing and Computation, enhancement, P5)

Description

[Matthew T (active 1999-2002)]

Build: 2001020513, Mac OS 9.0

To reproduce:
*   Open the Internet control panel.
*   In the `Colors & Links' section of the `Web' tab, select an unusual set of
    color and underlining options.
*   Close the Internet control panel, and save your changes.
*   Open the `Colors' category of prefs in Mozilla.
*   Check the `Use system colors' checkbox, and click `OK'.
*   Go to <http://www.yahoo.com/>.

What you should see:
*   Navigator using your unusual color and underlining preferences from the
    Internet control panel.

What you actually see:
*   Navigator using some non-Web-specific colors from the Appearance Manager.

If the `Use system colors' checkbox doesn't take its colors from the Internet 
control panel, it shouldn't be present on Mac OS at all.

See also bug 67769.

Comment 1

[timeless]

the ~if it's not perfect kill it~ argument does not belong in bugzilla.

Comment 2

[Matthew T (active 1999-2002)]

So don't make it.

Comment 3

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Once this is fixed (and by that I mean not only using the foreground and
background colors, but also the unvisited and visited link colors, which
requires a little more backend in gfx/style system), then it would be a good
thing to add a Mac-specific override to undo the change in bug 69053 which made
"Use System Colors" be off by default.

Comment 4

[Paul Chen]

So, after looking through the code, what "use system colors" means is use "web
background colour" for window background color
(http://lxr.mozilla.org/seamonkey/source/widget/src/mac/nsLookAndFeel.cpp#78)
and use "web text color" for text foreground color
(http://lxr.mozilla.org/seamonkey/source/widget/src/mac/nsLookAndFeel.cpp#116)
and that's it. Sounds like some work needs to be done. ;-)

Marking p3 and mozilla1.0

Comment 5

[Paul Chen]

pushing out to mozilla1.1

Comment 6

[Asa Dotzler [:asa]]

-> default assignee

Comment 7

[Samir Gehani]

Over to a mac expert: sfraser.

Comment 8

[Simon Fraser [no longer active]]

Whaaa. Back to default owner. I'll be glad to give advice, but don't have cycles 
to work on this.

Comment 9

[Peter Trudelle]

Samir says this is hooked up from prefs front end, pref is just not being
honored.   ->style system

Comment 10

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Using the internet control panel is more than just "Use System Colors".  This
needs a Mac person -- we'd probably want to create
-moz-{WebForeground,WebBackground,WebLink,WebVLink,WebALink} system colors or
something like that, and then use them on Mac only, since the "real" system
colors probably should be the ones for the system, not the ones for web pages
(although perhaps that's arguable -- I'd need to look at the spec and perhaps
discuss it with the WG).

Anyway, this has been bounced around enough, so I'll just future it, and anybody
who has plans to fix it can take it.

Comment 11

[Matthew T (active 1999-2002)]

As far as I can see there is no sensible intersection between `system colors' 
and CSS UI colors at all. The settings in the Internet control panel are used 
by Web browsers (except Mozilla) when coloring HTML, not for anything else.

Comment 12

[Simon Paquet [:sipaq]]

This bug is targeted at a Mac classic platform/OS, which is no longer supported
by mozilla.org. Please re-target it to another platform/OS if this bug applies
there as well or resolve this bug.

I will resolve this bug as WONTFIX in four weeks if no action has been taken.
To filter this and similar messages out, please filter for "mac_cla_reorg".

Comment 13

[Boris Zbarsky [:bzbarsky]]

Note that Apple has completely removed this control panel in Panther.  Oops.  I
suspect that the only way to set these "system-wide" settings now is to set them
in Safari.