677785 - Allow some hotkeys without a modifier

Status: RESOLVED FIXED

(Add-on SDK Graveyard :: General, defect, P2)

Description

[Mark Hammond [:markh] [:mhammond]]

If you try and create a hotkey without a modifier, you hit the code in hotkeys.js:
"""
const INVALID_HOTKEY = "Hotkey must have at least one modifier.";
...
  if (!hotkey.modifiers.length) {
    throw new TypeError(INVALID_HOTKEY);
  }
"""

I'd like to use the "F1" key for F1/Firefox Share, but this prevents me.

If the intent of the restriction is to prevent things like unmodified alpha keys being used, then I'd suggest a different strategy be used to detect such keys - currently a "shift-" modifier is allowed for these keys which is only slightly less evil than the unmodified version.

I could try and help with a patch if this is accepted and I can understand the intent of the restriction.

Comment 1

[Myk Melez [:myk] [@mykmelez]]

"F1" seems like a perfectly reasonable hotkey for the F1 addon, and we should support registering it via the Hotkeys API, whether we do so by enabling the registration of all unmodified keys or just certain ones (f.e. non-alphanumerics).

Comment 2

[Myk Melez [:myk] [@mykmelez]]

Also cc:ing Irakli, who's involved in that API's implementation, for his input.

Comment 3

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

(Pushing all open bugs to the --- milestone for the new triage system)

Comment 4

[Irakli Gozalishvili [:irakli] [:gozala] [@gozala]]

I think we should restrict that to non printables, cause otherwise your hotkey will be executed even if users type in search-box or address-bar

Comment 5

[Irakli Gozalishvili [:irakli] [:gozala] [@gozala]]

Attachment: Pointer to Github pull request: https://github.com/mozilla/addon-sdk/pull/242

Pointer to Github pull-request

Comment 6

[Alexandre Poirot [:ochameau]]

Comment on attachment 564838 [details]
Pointer to Github pull request: https://github.com/mozilla/addon-sdk/pull/242

Seems good to take. I think we may have to allow other keys without modifiers,
but let's get this improvement now. It will be easy to allow extra keys by renaming this isFunctionKey().

Comment 7

[Irakli Gozalishvili [:irakli] [:gozala] [@gozala]]

https://github.com/mozilla/addon-sdk/commit/4664ac42fe383c3bbb7f6dd5e18e6b4e715c1c65