Closed Bug 677880 Opened 9 years ago Closed 8 years ago

get rid of nsIScriptableInterfaces

Categories

(Core :: XPConnect, defect)

x86_64
Linux
defect
Not set

Tracking

()

RESOLVED FIXED
mozilla9

People

(Reporter: arno, Assigned: arno)

Details

(Whiteboard: [inbound])

Attachments

(1 file)

Hi,
Currently, Components.interfaces implements nsIScriptableInterfaces and can be invoked with contract id "@mozilla.org/scriptableinterfaces;1"
That interface allow to define an non default nsIInterfaceInfoManager for Components.interfaces

See bug #123770
It looks unused today. So maybe, nsIScriptableInterfaces can be simplified back to nsIXPCComponents_Interfaces.
That would be more consistent with other Components property.
patch proposal:
remove setManager, rename nsIScriptableInterfaces to 
nsIXPCComponents_Interfaces, define it in xpccomponents.idl, and make Components.interfaces not an xpcom object anymore
I've tested this patch already. It looks like it breaks nothing:
http://tbpl.mozilla.org/?tree=Try&rev=3adb6f0528ac
Attachment #552055 - Flags: review?(mrbkap)
Comment on attachment 552055 [details] [diff] [review]
rename nsIScriptableInterfaces and nsIScriptableInterfacesByID

Yes, please.
Attachment #552055 - Flags: review?(mrbkap) → review+
Assignee: nobody → arno
http://hg.mozilla.org/mozilla-central/rev/b23c1a9de86c
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla9
You need to log in before you can comment on or make changes to this bug.