get rid of nsIScriptableInterfaces

RESOLVED FIXED in mozilla9

Status

()

Core
XPConnect
RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: arno renevier, Assigned: arno renevier)

Tracking

unspecified
mozilla9
x86_64
Linux
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [inbound])

Attachments

(1 attachment)

(Assignee)

Description

6 years ago
Hi,
Currently, Components.interfaces implements nsIScriptableInterfaces and can be invoked with contract id "@mozilla.org/scriptableinterfaces;1"
That interface allow to define an non default nsIInterfaceInfoManager for Components.interfaces

See bug #123770
It looks unused today. So maybe, nsIScriptableInterfaces can be simplified back to nsIXPCComponents_Interfaces.
That would be more consistent with other Components property.
(Assignee)

Comment 1

6 years ago
Created attachment 552055 [details] [diff] [review]
rename nsIScriptableInterfaces and nsIScriptableInterfacesByID

patch proposal:
remove setManager, rename nsIScriptableInterfaces to 
nsIXPCComponents_Interfaces, define it in xpccomponents.idl, and make Components.interfaces not an xpcom object anymore
(Assignee)

Comment 2

6 years ago
I've tested this patch already. It looks like it breaks nothing:
http://tbpl.mozilla.org/?tree=Try&rev=3adb6f0528ac
(Assignee)

Updated

6 years ago
Attachment #552055 - Flags: review?(mrbkap)
Comment on attachment 552055 [details] [diff] [review]
rename nsIScriptableInterfaces and nsIScriptableInterfacesByID

Yes, please.
Attachment #552055 - Flags: review?(mrbkap) → review+

Updated

6 years ago
Assignee: nobody → arno
http://hg.mozilla.org/integration/mozilla-inbound/rev/b23c1a9de86c
Whiteboard: [inbound]
http://hg.mozilla.org/mozilla-central/rev/b23c1a9de86c
Status: NEW → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla9
You need to log in before you can comment on or make changes to this bug.