67789 - javascript strict warnings in contentAreaDD.js

Status: RESOLVED FIXED

(Core :: DOM: Copy & Paste and Drag & Drop, defect)

Description

[Henrik Gemal]

JavaScript strict warning:
chrome://communicator/content/contentAreaDD.js line 138: anonymous function does
 not always return a value

Comment 1

[Chris McAfee]

over to ben, adding alecf; two recent owners of this file.

Comment 2

[Håkan Waara]

Any volunteers up to fix this, mao?

Comment 3

[Henrik Gemal]

The error has now changed to:
JavaScript strict warning:
chrome://communicator/content/contentAreaDD.js line 146: anonymous function does
 not always return a value

Comment 4

[bht237]

Newbie would like to help. Looks like "return true" or "return false" is needed
between lines 145 and 146. Don't know what "onDragStart: function (aEvent,
aXferData, aDragAction)" is supposed to return.
Is there documentation? How to submit the updated file?

Comment 5

[timeless]

if possible, please get cvs tools (try wincvs.org, cvshome.org)
read http://www.mozilla.org/cvs.html
change the file
run cvs diff -u > mychanges.patch
attach that file.

on Events usually return false to indicate an abort condition
and true is often returned to indicate that an event was handled by the handler

not sure which is correct in this case.

you should probably try both return values and see which one is less broken.

Comment 6

[Mark Olson]

Attachment: patch - return true if we get to the bottom of the function

Comment 7

[Håkan Waara]

I think there are other functions in that file that doesn't always return a
value as well. Can you fix them too?   r=hwaara

Comment 8

[Mark Olson]

hwaara, the other functions are fine as is.

Comment 9

[sairuh (rarely reading bugmail)]

->d'n'd. i think. punt back if that's the wrong component!

Comment 10

[Blake Ross]

-> Mark

Comment 11

[Alexey Chernyak]

Warning now is:

Warning: anonymous function does not always return a value
Source File: chrome://communicator/content/contentAreaDD.js
Line: 151, Column: 4
Source Code:
    },

Comment 12

[Alex Vincent [:WeirdAl]]

No sign of this warning in Mozilla/5.0 (Windows; U; Win98; en-US; rv:0.9.7+)
Gecko/20020105

It's been six months since anyone commented on this bug.  Can someone tell me
how to reproduce this strict warning?

Comment 13

[bht237]

If I add to my preferences

user_pref("javascript.options.strict", true);
user_pref("javascript.options.werror", false);

then I see errors and warnings such as:

Error: redeclaration of const hide
Source File: chrome://wallet/content/walletOverlay.js
Line: 1

Warning: assignment to undeclared variable showMiscellaneousSeparator
Source File: chrome://navigator/content/linkToolbarItem.js
Line: 266

Warning: assignment to undeclared variable LinkToolbarUI
Source File: chrome://navigator/content/linkToolbarOverlay.js
Line: 50

I could NOT reproduce the original error.
I think maybe this bug is not so much concerned with the specific error but with
the fact there is some kind of error in the JavaScript console.
If you click on the error then the javascript source file opens. Quite nice!

Comment 14

[Stephen Walker]

Using today's trunk build, I'm getting:

Warning: trailing comma is not legal in ECMA-262 object initializers
Source File: chrome://communicator/content/contentAreaDD.js
Line: 83
Source Code:
};

Comment 15

[Henrik Gemal]

Attachment: path to fix strict warn

Comment 16

[Henrik Gemal]

now we just need r, sr, a and checkin...

Comment 17

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 73380 [details] [diff] [review]
path to fix strict warn

r=bzbarsky

Comment 18

[Alec Flett]

Comment on attachment 73380 [details] [diff] [review]
path to fix strict warn

sr=alecf

Comment 19

[Scott Collins]

Comment on attachment 73380 [details] [diff] [review]
path to fix strict warn

a=scc

Comment 20

[Christopher Aillon (sabbatical, not receiving bugmail)]

Checked in.  Thanks Henrik!