67790 - javascript strict warnings in bookmarksOverlay.js

Status: RESOLVED FIXED

(SeaMonkey :: Bookmarks & History, defect)

Description

[Henrik Gemal]

JavaScript strict warning:
chrome://communicator/content/bookmarks/bookmarksOverlay.js line 345: 
redeclaration of var args

Comment 1

[Henrik Gemal]

And when selecting all bookmarks and pressing delete:
************************************************************
* Call to xpconnect wrapped JSObject produced this error:  *
[Exception... "[Exception... "Illegal value"  code: "-2147024809" nsresult: "0x8
0070057 (NS_ERROR_ILLEGAL_VALUE)"  location: "chrome://communicator/content/book
marks/bookmarksOverlay.js Line: 582"] [nsIController::doCommand]"  nsresult: "0x
8057001c (NS_ERROR_XPC_JS_THREW_JS_OBJECT)"  location: "JS frame :: chrome://glo
bal/content/globalOverlay.js :: goDoCommand :: line 71"  data: no]
************************************************************
An error occurred executing the cmd_delete command
************************************************************
* Call to xpconnect wrapped JSObject produced this error:  *
[Exception... "Component returned failure code: 0x8000ffff (NS_ERROR_UNEXPECTED)
 [nsIRDFDataSource.DoCommand]"  nsresult: "0x8000ffff (NS_ERROR_UNEXPECTED)"  lo
cation: "JS frame :: chrome://communicator/content/bookmarks/bookmarksOverlay.js
 :: anonymous :: line 379"  data: no]
************************************************************

Comment 2

[Mark Olson]

Attachment: patch - fix strict warnings

Comment 3

[Mark Olson]

The patch fixes the strict warnings, but doesn't attempt to touch the exception.
 That should be another bug anyway.

Comment 4

[timeless]

r=timeless, a=alecf

Comment 5

[timeless]

fix checked in. henrik please file another bug for the js exception if it's 
still present.

Comment 6

[Henrik Gemal]

JavaScript strict warning:
chrome://communicator/content/bookmarks/bookmarksOverlay.js line 325: redeclarat
ion of var args

Comment 7

[Mark Olson]

Attachment: patch - fix re-emergent warning

Comment 8

[Peter "jag" Annema]

r=jag

Comment 9

[Ben Goodger (use ben at mozilla dot org for email)]

a=[e-mail].

'booya'

Comment 10

[Mark Olson]

fix checked in

Comment 11

[Henrik Gemal]

After going to:
ftp://ftp.danadata.dk/pub/McAfee/McAfee/antivirus/dat/4.x/extra/
and pressing "Add Bookmark"

JavaScript strict warning:
chrome://communicator/content/bookmarks/bookmarksOverlay.js line 807: reference
to undefined property aDocShell.document.title

build 20010420

Comment 12

[Boris Zbarsky [:bzbarsky]]

Attachment: Fix the aDocShell.document.title warning

Comment 13

[Boris Zbarsky [:bzbarsky]]

That fixes the warning... reviews?

Comment 14

[timeless]

is try needed?

var title = url, docCharset = null;
if (title in aDocShell.document && aDocShell.document.title)
  title = aDocShell.document.title;
docCharset = aDocShell.document.characterSet;

//i'm not sure if this is cheaper.

Comment 15

[Henrik Gemal]

btw:

JavaScript error:
 line 7: uncaught exception: [Exception... "Component returned failure code: 
0x80004002 (NS_NOINTERFACE) [nsIRDFNode.QueryInterface]"  nsresult: "0x80004002 
(NS_NOINTERFACE)"  location: "JS frame :: 
chrome://communicator/content/bookmarks/bookmarksOverlay.js :: LITERAL :: line 
61"  data: no]

************************************************************
* Call to xpconnect wrapped JSObject produced this error:  *
[Exception... "Component returned failure code: 0x80004002 (NS_NOINTERFACE) 
[nsIRDFNode.QueryInterface]"  nsresult: "0x80004002 (NS_NOINTERFACE)"  location: 
"JS frame :: chrome://communicator/content/bookmarks/bookmarksOverlay.js :: 
LITERAL :: line 61"  data: no]
************************************************************
An error occurred executing the cmd_bm_delete command

Comment 16

[Oliver Klee]

Filed bug 78968 about another JS Error in bookmarksOverlay.js.

Comment 17

[Henrik Gemal]

ben: is it correct that this one is invalid after you bookmark rework?

Comment 18

[Henrik Gemal]

in build 20010826 when doing paste into a empty manage bookmark window

Error: lastSelected has no properties
Source File: chrome://communicator/content/bookmarks/bookmarksOverlay.js
Line: 531

Comment 19

[Stephen Walker]

Using a trunk build from today.

Warning: anonymous function does not always return a value
Source File: chrome://communicator/content/bookmarks/bookmarksOverlay.js
Line: 862, Column: 58
Source Code:
    return BMSvc.createFolderEx(aTitle, aParentFolder, ix);

Comment 20

[Christian :Biesinger (don't email me, ping me on IRC)]

Attachment: patch for the warning stephen mentioned

Comment 21

[Stephen Walker]

Comment on attachment 80662 [details] [diff] [review]
patch for the warning stephen mentioned

r=walk84

Comment 22

[Alec Flett]

Comment on attachment 80662 [details] [diff] [review]
patch for the warning stephen mentioned

sr=alecf

Comment 23

[Christian :Biesinger (don't email me, ping me on IRC)]

checked in