67792 - javascript strict warnings in bookmarksTree.js

Status: VERIFIED FIXED

(SeaMonkey :: Bookmarks & History, defect, P5)

Description

[Henrik Gemal]

JavaScript strict warning:
chrome://communicator/content/bookmarks/bookmarksTree.js line 42: deprecated 
__proto__ usage

Comment 1

[Ben Goodger (use ben at mozilla dot org for email)]

__proto__ is legal.

Comment 2

[Henrik Gemal]

JavaScript strict warning:
chrome://communicator/content/bookmarks/bookmarksTree.js line 249: redeclaration
 of var treechildren

Comment 3

[Boris Zbarsky [:bzbarsky]]

Attachment: patch to fix this

Comment 4

[Boris Zbarsky [:bzbarsky]]

reviews?

Comment 5

[timeless]

r=timeless

Comment 6

[Boris Zbarsky [:bzbarsky]]

Is this still an issue after the latest bookmarks rewrite?

Comment 7

[Henrik Gemal]

I'm not seeing this anymore. But if I see it again I'll reopen.

Comment 8

[Henrik Gemal]

Warning: redeclaration of var firstSelected
Source File: chrome://communicator/content/bookmarks/bookmarksTree.js
Line: 662, Column: 12
Source Code:
        var firstSelected = seln.length ? seln[0] : gBookmarksShell.tree;

Warning: redeclaration of var folderType
Source File: chrome://communicator/content/bookmarks/bookmarksTree.js
Line: 663, Column: 12
Source Code:
        var folderType = firstSelected.getAttribute("type") == (NC_NS + "Folder");

Warning: redeclaration of var bItemCountCorrect
Source File: chrome://communicator/content/bookmarks/bookmarksTree.js
Line: 664, Column: 12
Source Code:
        var bItemCountCorrect = seln.length ? numSelectedItems == 1 : true;

Warning: redeclaration of var firstSelected
Source File: chrome://communicator/content/bookmarks/bookmarksTree.js
Line: 668, Column: 12
Source Code:
        var firstSelected = seln.length ? seln[0] : gBookmarksShell.tree;

Warning: redeclaration of var folderType
Source File: chrome://communicator/content/bookmarks/bookmarksTree.js
Line: 669, Column: 12
Source Code:
        var folderType = firstSelected.getAttribute("type") == (NC_NS + "Folder");

Warning: redeclaration of var bItemCountCorrect
Source File: chrome://communicator/content/bookmarks/bookmarksTree.js
Line: 670, Column: 12
Source Code:
        var bItemCountCorrect = seln.length ? numSelectedItems == 1 : true;

Warning: redeclaration of var seln
Source File: chrome://communicator/content/bookmarks/bookmarksTree.js
Line: 673, Column: 12
Source Code:
        var seln = gBookmarksShell.tree.selectedItems;

build 20010527

Comment 9

[Boris Zbarsky [:bzbarsky]]

Over to bookmarks.

Comment 10

[[e-mail] (gone - use [e-mail] instead)]

*** Bug 101095 has been marked as a duplicate of this bug. ***

Comment 11

[Ben Goodger (use ben at mozilla dot org for email)]

This file will disappear with the advent of outliner bookmarks

Comment 12

[Ben Goodger (use ben at mozilla dot org for email)]

Paul Chen is now taking Bookmarks bugs. For your convenience, you can filter 
email notifications caused by this by searching for 'ilikegoats'.

Comment 13

[Paul Chen]

Mass move Ben's bugs dumped on me marked future with p5 to get off my untriaged
radar. You can filter out this email by looking for "ironstomachaussie"

Comment 14

[Peter Trudelle]

mass reassign of pchen bookmark bugs to ben

Comment 15

[Pierre Chanial]

the assertions got fixed by Blake.
http://bonsai.mozilla.org/cvsquery.cgi?treeid=default&module=all&branch=HEAD&branchtype=match&dir=&file=bookmarksTree.js&filetype=match&who=&whotype=match&sortby=Date&hours=2&date=all&mindate=&maxdate=&cvsroot=%2Fcvsroot

Comment 16

[Henrik Gemal]

v 20020222