If you think a bug might affect users in the 57 release, please set the correct tracking and status flags for Release Management.

dashboard initialized twice for each new window

RESOLVED FIXED

Status

Mozilla Labs
OpenWebApps
RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: mixedpuppy, Assigned: mixedpuppy)

Tracking

Details

Attachments

(1 attachment)

(Assignee)

Description

6 years ago
The browser ui component is initialized twice since the move to using jetpack.  The pre-jetpack code watches for new windows, and initalizes owa for that window, which would create a new panel for the dashboard.

Using the jetpack widget handles the per-window initialization for you.  The result is two attempts at initialization, causing errors and potentially other issues.

This patch cleans up the ui class, separating the dashboard into it's own class, only initializing the class at startup, allowing jetpack to control the per-window logic.
(Assignee)

Comment 1

6 years ago
Created attachment 552177 [details]
Pointer to pull request
Attachment #552177 - Flags: review?(anant)
(Assignee)

Updated

6 years ago
Blocks: 678010
(Assignee)

Updated

6 years ago
Assignee: nobody → mixedpuppy
Attachment #552177 - Flags: review?(anant) → review+
(Assignee)

Comment 2

6 years ago
merged
https://github.com/mozilla/openwebapps/commit/328f4d6c90775a064f4a4efb24f2ca194fad5286
Status: NEW → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.