Closed
Bug 677970
Opened 13 years ago
Closed 13 years ago
dashboard initialized twice for each new window
Categories
(Mozilla Labs :: OpenWebApps, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: mixedpuppy, Assigned: mixedpuppy)
References
Details
Attachments
(1 file)
The browser ui component is initialized twice since the move to using jetpack. The pre-jetpack code watches for new windows, and initalizes owa for that window, which would create a new panel for the dashboard. Using the jetpack widget handles the per-window initialization for you. The result is two attempts at initialization, causing errors and potentially other issues. This patch cleans up the ui class, separating the dashboard into it's own class, only initializing the class at startup, allowing jetpack to control the per-window logic.
|
Assignee | |
Comment 1•13 years ago
|
||
Attachment #552177 -
Flags: review?(anant)
|
|
Assignee | |
Updated•13 years ago
|
Assignee: nobody → mixedpuppy
|
||
Updated•13 years ago
|
Attachment #552177 -
Flags: review?(anant) → review+
|
|
Assignee | |
Comment 2•13 years ago
|
||
merged https://github.com/mozilla/openwebapps/commit/328f4d6c90775a064f4a4efb24f2ca194fad5286
Status: NEW → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•