Last Comment Bug 678008 - Fix elfhack build in c++0x mode
: Fix elfhack build in c++0x mode
Status: RESOLVED FIXED
:
Product: Core
Classification: Components
Component: Build Config (show other bugs)
: unspecified
: x86_64 Linux
: -- normal (vote)
: mozilla9
Assigned To: Rafael Ávila de Espíndola (:espindola) (not reading bugmail)
:
Mentors:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2011-08-10 12:42 PDT by Rafael Ávila de Espíndola (:espindola) (not reading bugmail)
Modified: 2011-08-18 03:48 PDT (History)
2 users (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
fix build (1.92 KB, patch)
2011-08-10 12:42 PDT, Rafael Ávila de Espíndola (:espindola) (not reading bugmail)
mh+mozilla: review-
Details | Diff | Splinter Review
new patch (1.50 KB, patch)
2011-08-11 06:22 PDT, Rafael Ávila de Espíndola (:espindola) (not reading bugmail)
mh+mozilla: review+
Details | Diff | Splinter Review

Description Rafael Ávila de Espíndola (:espindola) (not reading bugmail) 2011-08-10 12:42:07 PDT
Created attachment 552181 [details] [diff] [review]
fix build
Comment 1 Mike Hommey [:glandium] 2011-08-10 23:32:29 PDT
Comment on attachment 552181 [details] [diff] [review]
fix build

Review of attachment 552181 [details] [diff] [review]:
-----------------------------------------------------------------

::: build/unix/elfhack/elfhack.cpp
@@ +36,5 @@
>   * ***** END LICENSE BLOCK ***** */
>  
>  #undef NDEBUG
> +#define __STDC_LIMIT_MACROS
> +#include <stdint.h>

Using climits and UINT_MAX should be better.

::: build/unix/elfhack/elfxx.h
@@ +276,4 @@
>          throw std::runtime_error("Unsupported ELF class or data encoding");
>      }
>  
> +    static inline unsigned size(char ei_class)

Please use "unsigned int", even if there's no difference, that's what the rest of the code uses.
Comment 2 Rafael Ávila de Espíndola (:espindola) (not reading bugmail) 2011-08-11 06:22:31 PDT
Created attachment 552353 [details] [diff] [review]
new patch
Comment 3 :Ehsan Akhgari 2011-08-15 16:55:34 PDT
Rafael: reminder for landing.  :)
Comment 4 Rafael Ávila de Espíndola (:espindola) (not reading bugmail) 2011-08-16 06:06:10 PDT
It landed on glandium's elfhack repo. I assumed he wanted to do a full merge. Glandium, is that the case?
Comment 5 Marco Bonardo [::mak] 2011-08-18 03:47:45 PDT
http://hg.mozilla.org/mozilla-central/rev/565a69914c4b

Note You need to log in before you can comment on or make changes to this bug.