678008 - Fix elfhack build in c++0x mode

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Description

[Rafael Ávila de Espíndola (:espindola) (not reading bugmail)]

Attachment: fix build

Comment 1

[Mike Hommey [:glandium]]

Comment on attachment 552181 [details] [diff] [review]
fix build

Review of attachment 552181 [details] [diff] [review]:
-----------------------------------------------------------------

::: build/unix/elfhack/elfhack.cpp
@@ +36,5 @@
>   * ***** END LICENSE BLOCK ***** */
>  
>  #undef NDEBUG
> +#define __STDC_LIMIT_MACROS
> +#include <stdint.h>

Using climits and UINT_MAX should be better.

::: build/unix/elfhack/elfxx.h
@@ +276,4 @@
>          throw std::runtime_error("Unsupported ELF class or data encoding");
>      }
>  
> +    static inline unsigned size(char ei_class)

Please use "unsigned int", even if there's no difference, that's what the rest of the code uses.

Comment 2

[Rafael Ávila de Espíndola (:espindola) (not reading bugmail)]

Attachment: new patch

Comment 3

[(no longer active)]

Rafael: reminder for landing.  :)

Comment 4

[Rafael Ávila de Espíndola (:espindola) (not reading bugmail)]

It landed on glandium's elfhack repo. I assumed he wanted to do a full merge. Glandium, is that the case?

Comment 5

[Marco Bonardo [:mak]]

http://hg.mozilla.org/mozilla-central/rev/565a69914c4b