Closed Bug 678024 Opened 8 years ago Closed 8 years ago

Fix c++0x initializer list error found by clang

Categories

(Core :: IPC, defect)

x86_64
Linux
defect
Not set

Tracking

()

RESOLVED FIXED
mozilla8

People

(Reporter: espindola, Assigned: espindola)

Details

Attachments

(1 file, 1 obsolete file)

Fix build with c++0x and clang.
    geteuid returns an unsigned value, and in c++0x we need an explicit cast
    to int in an initializer list.
Attached patch fix build (obsolete) — Splinter Review
Attachment #552195 - Flags: review?(mh+mozilla)
Attachment #552195 - Flags: review?(mh+mozilla) → review?(jones.chris.g)
Comment on attachment 552195 [details] [diff] [review]
fix build

>-  int mib[] = { CTL_KERN, KERN_PROC, KERN_PROC_UID, geteuid() };
>+  int mib[] = { CTL_KERN, KERN_PROC, KERN_PROC_UID,
>+		static_cast<int>(geteuid()) };

Nit: |int(geteuid())|.
Attachment #552195 - Flags: review?(jones.chris.g) → review+
Attached patch updated patchSplinter Review
Attachment #552195 - Attachment is obsolete: true
Attachment #552483 - Flags: review?(jones.chris.g)
Attachment #552483 - Flags: review?(jones.chris.g) → review+
Assignee: nobody → respindola
Status: NEW → ASSIGNED
Pushed to inbound.
Keywords: checkin-needed
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.