Last Comment Bug 678028 - Fix c++0x initializer list error found by clang
: Fix c++0x initializer list error found by clang
Status: RESOLVED FIXED
:
Product: Core
Classification: Components
Component: ImageLib (show other bugs)
: unspecified
: x86_64 Linux
: -- normal (vote)
: mozilla9
Assigned To: Rafael Ávila de Espíndola (:espindola) (not reading bugmail)
:
Mentors:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2011-08-10 13:26 PDT by Rafael Ávila de Espíndola (:espindola) (not reading bugmail)
Modified: 2011-08-18 03:48 PDT (History)
2 users (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
fix build (27.98 KB, patch)
2011-08-10 13:26 PDT, Rafael Ávila de Espíndola (:espindola) (not reading bugmail)
joe: review+
Details | Diff | Splinter Review
program used to create the patch (3.74 KB, text/plain)
2011-08-16 10:20 PDT, Rafael Ávila de Espíndola (:espindola) (not reading bugmail)
no flags Details

Description Rafael Ávila de Espíndola (:espindola) (not reading bugmail) 2011-08-10 13:26:33 PDT
Created attachment 552198 [details] [diff] [review]
fix build

Fix build with clang in c++0x mode.
    In c++0x mode it is not valid to have an integer that doesn't fit a type
    in an initializer list. This patch just writes the constants as explicitly
    signed instead of using unsigned constants with 2 complement.
Comment 1 Joe Drew (not getting mail) 2011-08-16 09:33:22 PDT
Comment on attachment 552198 [details] [diff] [review]
fix build

Review of attachment 552198 [details] [diff] [review]:
-----------------------------------------------------------------

Add the bug number to your checkin comment, and plz to attach source of the program you used to create this ;)
Comment 2 Rafael Ávila de Espíndola (:espindola) (not reading bugmail) 2011-08-16 10:20:02 PDT
Created attachment 553515 [details]
program used to create the patch

What I did was run with program 4 times, each time with one of the tables and copy and paste them into the original files.
Comment 3 Marco Bonardo [::mak] 2011-08-18 03:47:02 PDT
http://hg.mozilla.org/mozilla-central/rev/8f315a50dcc9

Note You need to log in before you can comment on or make changes to this bug.