The default bug view has changed. See this FAQ.

Fix c++0x initializer list error found by clang

RESOLVED FIXED in mozilla9

Status

()

Core
ImageLib
RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: espindola, Assigned: espindola)

Tracking

unspecified
mozilla9
x86_64
Linux
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(2 attachments)

Created attachment 552198 [details] [diff] [review]
fix build

Fix build with clang in c++0x mode.
    In c++0x mode it is not valid to have an integer that doesn't fit a type
    in an initializer list. This patch just writes the constants as explicitly
    signed instead of using unsigned constants with 2 complement.
Attachment #552198 - Flags: review?(mh+mozilla)
Attachment #552198 - Flags: review?(mh+mozilla) → review?(joe)
Comment on attachment 552198 [details] [diff] [review]
fix build

Review of attachment 552198 [details] [diff] [review]:
-----------------------------------------------------------------

Add the bug number to your checkin comment, and plz to attach source of the program you used to create this ;)
Attachment #552198 - Flags: review?(joe) → review+
Created attachment 553515 [details]
program used to create the patch

What I did was run with program 4 times, each time with one of the tables and copy and paste them into the original files.
http://hg.mozilla.org/mozilla-central/rev/8f315a50dcc9
Status: NEW → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla9

Updated

6 years ago
Assignee: nobody → respindola
You need to log in before you can comment on or make changes to this bug.