678069 - Fix c++0x initializer list error found by clang

Status: RESOLVED FIXED

Description

[Rafael Ávila de Espíndola (:espindola) (not reading bugmail)]

Created attachment 552231 [details] [diff] [review]
fix build

Fix build with clang and c++0x. mShWidth and mShHeight are used in an initializer list for NPRect in fields that have time uint16_t. Change their definitions to match.

Comment 1

[Josh Aas]

Comment on attachment 552231 [details] [diff] [review]
fix build

mShWidth and mShHeight are also used for "CGBitmapContextCreate", which wants size_t, and "CGRectMake", which wants CGFloat. Is the logic here to make the stored value the smallest of all the requirements?

Comment 2

[Rafael Ávila de Espíndola (:espindola) (not reading bugmail)]

Almost. It is one that will not lose a value when going to uint16_t in a initializer list (which is the c++0x restriction).

Comment 3

[:Ms2ger (⌚ UTC+1/+2)]

http://hg.mozilla.org/mozilla-central/rev/9d083bbd47f5