678106 - IonMonkey: implement localinc

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[Hannes Verschore [:h4writer]]

implements JSOP_LOCALINC, JSOP_LOCALDEC, JSOP_INCLOCAL, JSOP_DECLOCAL.

Comment 1

[Hannes Verschore [:h4writer]]

Attachment: implement local increment/decrement

methodjit sometimes uses JSOP_SUB instead of JSOP_ADD. I think this isn't performance related, so this patch always uses JSOP_ADD

Comment 2

[David Anderson [:dvander] - inactive, e-mail if emergency]

Comment on attachment 552279 [details] [diff] [review]
implement local increment/decrement

Review of attachment 552279 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good, r=me with one nit:

::: js/src/ion/IonBuilder.cpp
@@ +1565,5 @@
> +        post_incr = false;
> +        break;
> +      default:
> +        JS_NOT_REACHED("Unsupported op");
> +    }

This switch block can probably be shortened to:

amt = (js_CodeSpec[op].format & JOF_INC) ? 1 : -1;
post_incr = !!(js_CodeSpec[op].format & JOF_POST);

Comment 3

[Hannes Verschore [:h4writer]]

(In reply to David Anderson [:dvander] from comment #2)
> This switch block can probably be shortened to:
> 
> amt = (js_CodeSpec[op].format & JOF_INC) ? 1 : -1;
> post_incr = !!(js_CodeSpec[op].format & JOF_POST);
Done

http://hg.mozilla.org/projects/ionmonkey/rev/73b80b0c344a

Comment 4

[Hannes Verschore [:h4writer]]

Attachment: tests

These are the tests I used. We should add them too.

Comment 5

[David Anderson [:dvander] - inactive, e-mail if emergency]

Comment on attachment 552437 [details] [diff] [review]
tests

Note that this whole thing will likely be constant folded away :)

Comment 6

[Hannes Verschore [:h4writer]]

(In reply to David Anderson [:dvander] from comment #5)
> Comment on attachment 552437 [details] [diff] [review]
> tests
> 
> Note that this whole thing will likely be constant folded away :)

True, so adjusted testcase a bit.

http://hg.mozilla.org/projects/ionmonkey/rev/e4815c23236d