Closed Bug 678189 Opened 8 years ago Closed 8 years ago

Crash [@ RelatedAccIterator::RelatedAccIterator(nsDocAccessible*, nsIContent*, nsIAtom*) ]

Categories

(Core :: Disability Access APIs, defect, critical)

x86_64
Windows 7
defect
Not set
critical

Tracking

()

RESOLVED FIXED
mozilla8

People

(Reporter: MarcoZ, Assigned: tbsaunde)

References

Details

(Keywords: crash, regression)

Crash Data

Attachments

(1 file, 1 obsolete file)

First appears in the August 11, 2011 nightly build and is a regression from bug 641838 (the AccessibleRelation dexpcom refactor).

I can reproduce this at will by:
1. with NVDA running, starting the Nightly.
2. Pressing Ctrl+L to go to the Location bar.
3. Starting to type something like about:buildconfig. After one, two letters, probably as soon as the list appears, I get a crash.

Report: https://crash-stats.mozilla.com/report/index/bp-a152e4e3-ebb8-4328-8e23-c42a72110811
Crash Signature: [@ RelatedAccIterator::RelatedAccIterator(nsDocAccessible*, nsIContent*, nsIAtom*) ] → RelatedAccIterator::RelatedAccIterator(nsDocAccessible*, nsIContent*, nsIAtom*)
Attached patch a thought (obsolete) — Splinter Review
aI'm a little skeptical this is the issue Marco had based on the stack, but that stack isn't really good enough to denie anything, and I'm pretty sure we want this patch anyway

so, which ever of you gets to it first or both of you if you like :)
Attachment #552482 - Flags: review?(surkov.alexander)
Attachment #552482 - Flags: review?(bolterbugz)
Comment on attachment 552482 [details] [diff] [review]
a thought

r=me (code inspection only)
Attachment #552482 - Flags: review?(bolterbugz) → review+
Comment on attachment 552482 [details] [diff] [review]
a thought

yes, this is right. Until we have good stack this is reasonable guess because IsDefunct() check was got rid.
Attachment #552482 - Flags: review?(surkov.alexander) → review+
Comment on attachment 552482 [details] [diff] [review]
a thought


>   VariantInit(pvarEndUpAt);
>+  nsAccessible *xpAccessibleStart = GetXPAccessibleFor(varStart);
>+  if (!xpAccessibleStart || IsDefunct())
>+    return E_FAIL;
> 

initialize variant after you are use in correct accessible
Assignee: nobody → trev.saunders
Attached patch patch to landSplinter Review
is this the whitespace you want around variant_init()?
Attachment #552482 - Attachment is obsolete: true
From my testing the try-server build, it appears that this bug fixes the crash.
https://hg.mozilla.org/mozilla-central/rev/febd4e26179c
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla8
Crash Signature: RelatedAccIterator::RelatedAccIterator(nsDocAccessible*, nsIContent*, nsIAtom*) → [@ RelatedAccIterator::RelatedAccIterator(nsDocAccessible*, nsIContent*, nsIAtom*) ]
You need to log in before you can comment on or make changes to this bug.