678189 - Crash [@ RelatedAccIterator::RelatedAccIterator(nsDocAccessible*, nsIContent*, nsIAtom*) ]

Status: RESOLVED FIXED

(Core :: Disability Access APIs, defect)

Description

[Marco Zehe (:MarcoZ)]

First appears in the August 11, 2011 nightly build and is a regression from bug 641838 (the AccessibleRelation dexpcom refactor).

I can reproduce this at will by:
1. with NVDA running, starting the Nightly.
2. Pressing Ctrl+L to go to the Location bar.
3. Starting to type something like about:buildconfig. After one, two letters, probably as soon as the list appears, I get a crash.

Report: https://crash-stats.mozilla.com/report/index/bp-a152e4e3-ebb8-4328-8e23-c42a72110811

Comment 1

[Trevor Saunders (:tbsaunde)]

Attachment: a thought

aI'm a little skeptical this is the issue Marco had based on the stack, but that stack isn't really good enough to denie anything, and I'm pretty sure we want this patch anyway

so, which ever of you gets to it first or both of you if you like :)

Comment 2

[David Bolter [:davidb] (NeedInfo me for attention)]

Comment on attachment 552482 [details] [diff] [review]
a thought

r=me (code inspection only)

Comment 3

[Trevor Saunders (:tbsaunde)]

try builds for that patch should show up at http://ftp.mozilla.org/pub/mozilla.org/firefox/try-builds/[e-mail]-66a378ab0860.

Comment 4

[alexander :surkov (:asurkov)]

Comment on attachment 552482 [details] [diff] [review]
a thought

yes, this is right. Until we have good stack this is reasonable guess because IsDefunct() check was got rid.

Comment 5

[alexander :surkov (:asurkov)]

Comment on attachment 552482 [details] [diff] [review]
a thought


>   VariantInit(pvarEndUpAt);
>+  nsAccessible *xpAccessibleStart = GetXPAccessibleFor(varStart);
>+  if (!xpAccessibleStart || IsDefunct())
>+    return E_FAIL;
> 

initialize variant after you are use in correct accessible

Comment 6

[Trevor Saunders (:tbsaunde)]

Attachment: patch to land

is this the whitespace you want around variant_init()?

Comment 7

[Trevor Saunders (:tbsaunde)]

landed on http://hg.mozilla.org/integration/mozilla-inbound/rev/febd4e26179c

Comment 8

[Marco Zehe (:MarcoZ)]

From my testing the try-server build, it appears that this bug fixes the crash.

Comment 9

[Matt Brubeck (:mbrubeck)]

https://hg.mozilla.org/mozilla-central/rev/febd4e26179c