Last Comment Bug 678216 - Fix c++0x initializer list error found by clang
: Fix c++0x initializer list error found by clang
Status: RESOLVED FIXED
:
Product: Core
Classification: Components
Component: General (show other bugs)
: Trunk
: x86_64 Linux
: -- normal (vote)
: mozilla8
Assigned To: Rafael Ávila de Espíndola (:espindola) (not reading bugmail)
:
:
Mentors:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2011-08-11 09:23 PDT by Rafael Ávila de Espíndola (:espindola) (not reading bugmail)
Modified: 2011-08-12 07:57 PDT (History)
2 users (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
fix build (2.46 KB, patch)
2011-08-11 09:23 PDT, Rafael Ávila de Espíndola (:espindola) (not reading bugmail)
cjones.bugs: review+
Details | Diff | Splinter Review
updated patch (2.39 KB, patch)
2011-08-11 13:51 PDT, Rafael Ávila de Espíndola (:espindola) (not reading bugmail)
cjones.bugs: review+
Details | Diff | Splinter Review

Description Rafael Ávila de Espíndola (:espindola) (not reading bugmail) 2011-08-11 09:23:07 PDT
Fix build with clang and c++0x.
    
    Use tighter types for some fields. These fields are used in
    
      CFGregorianDate gregorian = {
        exploded.year,
        exploded.month,
        exploded.day_of_month,
        exploded.hour,
        exploded.minute,
        seconds
      };
    
    and in CFGregorianDate the month, day, hour and minute fields are 8 bits. Let
    me know if I should also change the day_of_week and second fields.
Comment 1 Rafael Ávila de Espíndola (:espindola) (not reading bugmail) 2011-08-11 09:23:29 PDT
Created attachment 552391 [details] [diff] [review]
fix build
Comment 2 Chris Jones [:cjones] inactive; ni?/f?/r? if you need me 2011-08-11 12:02:43 PDT
Comment on attachment 552391 [details] [diff] [review]
fix build

Yes, please change those fields too.
Comment 3 Rafael Ávila de Espíndola (:espindola) (not reading bugmail) 2011-08-11 13:51:36 PDT
Created attachment 552494 [details] [diff] [review]
updated patch
Comment 4 :Ehsan Akhgari 2011-08-11 15:44:27 PDT
Pushed to inbound.
Comment 5 Matt Brubeck (:mbrubeck) 2011-08-12 07:57:31 PDT
https://hg.mozilla.org/mozilla-central/rev/5812274f4afb

Note You need to log in before you can comment on or make changes to this bug.