Fix c++0x initializer list error found by clang

RESOLVED FIXED in mozilla8

Status

()

Core
General
RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: espindola, Assigned: espindola)

Tracking

Trunk
mozilla8
x86_64
Linux
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

Fix build with clang and c++0x.
    
    Use tighter types for some fields. These fields are used in
    
      CFGregorianDate gregorian = {
        exploded.year,
        exploded.month,
        exploded.day_of_month,
        exploded.hour,
        exploded.minute,
        seconds
      };
    
    and in CFGregorianDate the month, day, hour and minute fields are 8 bits. Let
    me know if I should also change the day_of_week and second fields.
Created attachment 552391 [details] [diff] [review]
fix build
Attachment #552391 - Flags: review?(mh+mozilla)
Attachment #552391 - Flags: review?(mh+mozilla) → review?(jones.chris.g)
Comment on attachment 552391 [details] [diff] [review]
fix build

Yes, please change those fields too.
Attachment #552391 - Flags: review?(jones.chris.g) → review+
Created attachment 552494 [details] [diff] [review]
updated patch
Attachment #552391 - Attachment is obsolete: true
Attachment #552494 - Flags: review?(jones.chris.g)
Attachment #552494 - Flags: review?(jones.chris.g) → review+
Pushed to inbound.
Assignee: nobody → respindola
Whiteboard: [inbound]
Target Milestone: --- → mozilla8
Version: unspecified → Trunk
https://hg.mozilla.org/mozilla-central/rev/5812274f4afb
Status: NEW → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
Whiteboard: [inbound]
You need to log in before you can comment on or make changes to this bug.