Closed
Bug 678216
Opened 13 years ago
Closed 13 years ago
Fix c++0x initializer list error found by clang
Categories
(Core :: General, defect)
Tracking
()
RESOLVED
FIXED
mozilla8
People
(Reporter: espindola, Assigned: espindola)
Details
Attachments
(1 file, 1 obsolete file)
2.39 KB,
patch
|
cjones
:
review+
|
Details | Diff | Splinter Review |
Fix build with clang and c++0x. Use tighter types for some fields. These fields are used in CFGregorianDate gregorian = { exploded.year, exploded.month, exploded.day_of_month, exploded.hour, exploded.minute, seconds }; and in CFGregorianDate the month, day, hour and minute fields are 8 bits. Let me know if I should also change the day_of_week and second fields.
Assignee | ||
Comment 1•13 years ago
|
||
Attachment #552391 -
Flags: review?(mh+mozilla)
Updated•13 years ago
|
Attachment #552391 -
Flags: review?(mh+mozilla) → review?(jones.chris.g)
Comment on attachment 552391 [details] [diff] [review] fix build Yes, please change those fields too.
Attachment #552391 -
Flags: review?(jones.chris.g) → review+
Assignee | ||
Comment 3•13 years ago
|
||
Attachment #552391 -
Attachment is obsolete: true
Attachment #552494 -
Flags: review?(jones.chris.g)
Updated•13 years ago
|
Attachment #552494 -
Flags: review?(jones.chris.g) → review+
Comment 4•13 years ago
|
||
Pushed to inbound.
Updated•13 years ago
|
Assignee: nobody → respindola
Whiteboard: [inbound]
Target Milestone: --- → mozilla8
Version: unspecified → Trunk
Comment 5•13 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/5812274f4afb
Status: NEW → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Whiteboard: [inbound]
You need to log in
before you can comment on or make changes to this bug.
Description
•