The default bug view has changed. See this FAQ.

Fix c++0x initializer list error found by clang

RESOLVED FIXED in mozilla8

Status

()

Core
Graphics
RESOLVED FIXED
6 years ago
5 years ago

People

(Reporter: espindola, Unassigned)

Tracking

unspecified
mozilla8
x86_64
Linux
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

Created attachment 552404 [details] [diff] [review]
fix build

Fix build with clang and c++0x.
Change AppUnitsPerDevPixel to return a PRUint32. It should never return
negative values and it is used in initializer lists that expect unsigned
values, which is not valid c++0x.

I have also change the member variables to be unsigned and converted
a sentinel value to use 0 instead of -1. UINT32_MAX should work fine too
if you like it better.
Attachment #552404 - Flags: review?(mh+mozilla)
Attachment #552404 - Flags: review?(mh+mozilla) → review?(roc)
Attachment #552404 - Flags: review?(roc) → review+
Pushed to inbound.
https://hg.mozilla.org/mozilla-central/rev/8a2432d7f8f3
Status: NEW → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla8
Depends on: 729781
Depends on: 731393
You need to log in before you can comment on or make changes to this bug.