678233 - Default license between builder and amo

Status: RESOLVED FIXED

(addons.mozilla.org Graveyard :: API, defect)

Description

[Andy McKay]

Piotr and I were chatting in #flightdeck and we couldn't agree. What license should Add-ons use when being created in AMO. Piotr thought it should be up to AMO to decide, I think it should be up to builder... but it should be something.

Comment 1

[Wil Clouser [:clouserw]]

I think the only way you could get around prompting would be an agreement on the builder side that says "By uploading to AMO with this tool you're assigning an MPL license to your code" or something.  I'm not a lawyer though.

So, I guess I'm saying the builder should provide the license to the AMO API, whether it solicits the license per upload or just as a part of a general agreement.

Does that make sense?

Comment 2

[Justin Scott [:fligtar]]

We definitely should not assign a default license.

Comment 3

[Andy McKay]

So we'll require a user to pick a license on builder and send that to AMO?

Comment 4

[Justin Scott [:fligtar]]

We could do that or just not store a license until the dev comes to AMO for some reason.

Comment 5

[Andy McKay]

I also suggested to Piotr that addons go into the Preliminary Review queue. Perhaps if there's no license it stays as Incomplete.

Comment 6

[Wil Clouser [:clouserw]]

Something that we talked about in the builder meeting was to get an add-on in the system (incomplete) and then dump the user on step 3 or whatever so they could complete whatever steps they needed, including icons, screenshots, licenses, etc.

Then after all those steps we could link back to builder or something.

That works for new add-ons, for new versions I think we'd be ok using the license of the version before.  Thoughts?

Comment 7

[Wil Clouser [:clouserw]]

Alright, let's go with that.

Comment 8

[Andy McKay]

http://github.com/jbalogh/zamboni/commit/08e209

Removing ability to specify a review queue. Users can complete all this stuff on the AMO side.