Closed
Bug 678239
Opened 13 years ago
Closed 13 years ago
IonMonkey: implement JSOP_SETARG
Categories
(Core :: JavaScript Engine, defect)
Core
JavaScript Engine
Tracking
()
RESOLVED
FIXED
People
(Reporter: h4writer, Assigned: h4writer)
References
Details
Attachments
(1 file)
905 bytes,
patch
|
dvander
:
review+
|
Details | Diff | Splinter Review |
implement JSOP_SETARG in IonMonkey
Assignee | ||
Comment 1•13 years ago
|
||
implementation + patch
Assignee: general → hv1989
Attachment #552435 -
Flags: review?(dvander)
Assignee | ||
Comment 2•13 years ago
|
||
patch => test ;)
Comment on attachment 552435 [details] [diff] [review] implement JSOP_SETARG Could you also include a test like? function f(x, y) { if (1) x = "5"; return x - y; } assertEq(f(0, 2), 3) Basically we want to make sure that snapshots are capturing the new definition for arguments, so when this bails back to the interpreter it correctly sees "5" instead of 0.
Attachment #552435 -
Flags: review?(dvander) → review+
Assignee | ||
Comment 4•13 years ago
|
||
http://hg.mozilla.org/projects/ionmonkey/rev/f82e7d7508f8
Status: NEW → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•