Closed
Bug 678259
Opened 10 years ago
Closed 10 years ago
Implement mozIVisitInfoCallback::handleResult to avoid exception
Categories
(Firefox :: Sync, defect)
Firefox
Sync
Tracking
()
RESOLVED
FIXED
mozilla8
People
(Reporter: philikon, Assigned: philikon)
References
Details
Attachments
(1 file)
941 bytes,
patch
|
rnewman
:
review+
|
Details | Diff | Splinter Review |
Turns out, methods on mozIVisitInfoCallback aren't as optional as we want them to be. If they're missing, XPConnect will still create + log an exception (bug 678129). It might not be thrown, but we'd really want to avoid it. For now we can just add a simple counter-measure by adding an empty handleResult method to Sync's callback object.
Assignee | ||
Updated•10 years ago
|
Summary: Implement mozIVisitInfoCallback::handleResult to avoid → Implement mozIVisitInfoCallback::handleResult to avoid exception
Assignee | ||
Comment 1•10 years ago
|
||
Attachment #552455 -
Flags: review?(rnewman)
Comment 2•10 years ago
|
||
Comment on attachment 552455 [details] [diff] [review] v1 Review of attachment 552455 [details] [diff] [review]: ----------------------------------------------------------------- Well, that's enjoyably trivial :)
Attachment #552455 -
Flags: review?(rnewman) → review+
Assignee | ||
Comment 3•10 years ago
|
||
http://hg.mozilla.org/integration/mozilla-inbound/rev/c7c13a66ad61
Whiteboard: [inbound]
Comment 4•10 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/c7c13a66ad61
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Whiteboard: [inbound]
Target Milestone: --- → mozilla8
Updated•3 years ago
|
Component: Firefox Sync: Backend → Sync
Product: Cloud Services → Firefox
You need to log in
before you can comment on or make changes to this bug.
Description
•