Assignments to innerHTML from function return values are ignored.

RESOLVED FIXED in 2012-09-06

Status

RESOLVED FIXED
8 years ago
3 years ago

People

(Reporter: kmag, Unassigned)

Tracking

unspecified
2012-09-06

Details

(Reporter)

Description

8 years ago
Lines like the following, which should be flagged, are ignored:

   foo.innerHTML = bar();

I've come across quite a lot of these recently but hadn't gotten around to tracking them down. The last one was a major remote chrome code execution vulnerability, so it would be nice to have this fixed soon.
Fixed:

https://github.com/mozilla/amo-validator/commit/f04ea51e27c5e25e24d3ef17b82fcc2a987abdce
Status: NEW → RESOLVED
Last Resolved: 7 years ago
Resolution: --- → FIXED

Updated

7 years ago
Target Milestone: --- → 2012-09-06
Product: addons.mozilla.org → addons.mozilla.org Graveyard
You need to log in before you can comment on or make changes to this bug.