Closed Bug 678264 Opened 14 years ago Closed 13 years ago

Assignments to innerHTML from function return values are ignored.

Categories

(addons.mozilla.org Graveyard :: Add-on Validation, defect)

Product:
addons.mozilla.org Graveyard
Component:
Add-on Validation
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED
Milestone:
2012-09-06

People

(Reporter: kmag, Unassigned)

Details

Lines like the following, which should be flagged, are ignored: foo.innerHTML = bar(); I've come across quite a lot of these recently but hadn't gotten around to tracking them down. The last one was a major remote chrome code execution vulnerability, so it would be nice to have this fixed soon.
Fixed: https://github.com/mozilla/amo-validator/commit/f04ea51e27c5e25e24d3ef17b82fcc2a987abdce
Status: NEW → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Target Milestone: --- → 2012-09-06
Product: addons.mozilla.org → addons.mozilla.org Graveyard
You need to log in before you can comment on or make changes to this bug.