678345 - Cancel is ambiguous when saving multiple attachments and overwriting files

Status: ASSIGNED

(Thunderbird :: Message Reader UI, defect)

Description

[Wayne Mery (:wsmwk)]

+++ This bug was initially created as a clone of Bug #448588 +++

PROBLEM 1:
It is unclear what the "Cancel" button will do.
It turns out that it means "Do not overwrite this one file but instead pop up a replacement dialog asking the user for a new filename", but it could equally plausibly have meant "Cancel entire Save All/Detach All action"

Comment 1

[Jim Porter (:squib)]

How about something like this?

+- File Conflict -------------------------- X +
|                                             |
| [ ! ] /path/to/file.txt already exists. Do  |
|       you want to replace it?               |
|                                             |
| [ ] Do this for all conflicts               |
|                        [ Skip ] [ Replace ] |
+---------------------------------------------+

"Cancel entire Save All/Detach All action" would be handled by checking the "do this for all conflicts" button and hitting "skip". We could add a cancel button too, but I'm not sure that's necessary.

We could also improve this even further by using the OS-native dialogs here, but that's more work. I can do the above with just a couple of simple changes.

Comment 2

[Jim Porter (:squib)]

Attachment: WIP patch

Here is a WIP patch to do this; I've only lightly tested this, so it might break things in strange and interesting ways.

Comment 3

[Jim Porter (:squib)]

Attachment: Fix bitrot

This fixes the bitrot in the old patch (mostly due to nsILocalFile going away). Does this seem reasonable? The UI looks like this now:

+- File Conflict -------------------------- X +
|                                             |
| [ ! ] /path/to/file.txt already exists. Do  |
|       you want to replace it?               |
|                                             |
| [ ] Do this for all conflicts               |
| [ Rename ]             [ Skip ] [ Replace ] |
+---------------------------------------------+

Rename automatically gives the file a unique name, skip just doesn't save the file, and replace overwrites the old file.

Comment 4

[Blake Winton (:bwinton) (:☕️)]

Comment on attachment 649050 [details] [diff] [review]
Fix bitrot

ui-r=me, based on your "screenshot".  :)

(Seriously, though, that seems like the right behaviour.)

Comment 5

[Magnus Melin [:mkmelin]]

Bitrotted, but this looks fairly ready otherwise.

Comment 6

[Wayne Mery (:wsmwk)]

(In reply to Magnus Melin from comment #5)
> Bitrotted, but this looks fairly ready otherwise.

want to take it over?

Comment 7

[Wayne Mery (:wsmwk)]

Comment on attachment 649050 [details] [diff] [review]
Fix bitrot

Bienvenu isn't going to touch this unless it's absolutely essential and we contact him outside of bugzilla.

Comment 8

[Magnus Melin [:mkmelin]]

(In reply to Wayne Mery (:wsmwk) from comment #6)
> (In reply to Magnus Melin from comment #5)
> > Bitrotted, but this looks fairly ready otherwise.
> 
> want to take it over?

Not atm.