dirSvc in mailShutdown.js should be an nsIDirectoryService

RESOLVED FIXED in Thunderbird 19.0

Status

MailNews Core
Testing Infrastructure
RESOLVED FIXED
6 years ago
5 years ago

People

(Reporter: rkent, Assigned: rkent)

Tracking

unspecified
Thunderbird 19.0

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

6 years ago
These lines in mailShutdown.js suddenly started failing in my extension tests:

if (gProfileDirProvider) {
  var dirSvc = Cc["@mozilla.org/file/directory_service;1"]
    .getService(Ci.nsIProperties);
  dirSvc.unregisterProvider(gProfileDirProvider);
 }

It fails because unregisterProvider needs nsIDirectoryService

Not sure why this has worked (supposedly) for years. I'll assign it to myself, and maybe get around to fixing it.
(Assignee)

Updated

6 years ago
Assignee: nobody → kent
(Assignee)

Comment 1

5 years ago
Created attachment 667510 [details] [diff] [review]
Switch to Services and QI interface
Attachment #667510 - Flags: review?(mbanner)
(Assignee)

Updated

5 years ago
Status: NEW → ASSIGNED
Comment on attachment 667510 [details] [diff] [review]
Switch to Services and QI interface

Review of attachment 667510 [details] [diff] [review]:
-----------------------------------------------------------------

::: mailnews/test/resources/mailShutdown.js
@@ +8,5 @@
>  //
>  // See also http://developer.mozilla.org/en/Observer_Notifications
>  function postShutdownNotifications()
>  {
> +  var observerService = Services.obs;

I think we can just drop the intermediate variable, Services.obs is shorter than that.

r=me with that fixed.
Attachment #667510 - Flags: review?(mbanner) → review+
(Assignee)

Comment 3

5 years ago
Checked in http://hg.mozilla.org/comm-central/rev/796aa4b31867
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
OS: Windows 7 → All
Hardware: x86_64 → All
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 19.0
You need to log in before you can comment on or make changes to this bug.