678357 - Saved searches results in a bug list is not being limited by the 'limit' parameter

Status: RESOLVED FIXED

(Bugzilla :: Query/Bug List, defect)

Description

[Tiago Mello [:timello]]

Attachment: v1

It is sometimes very useful to save a query with a limit for the results.

We are overriding the limit value with the default_limited when we shouldn't.

Comment 1

[Max Kanat-Alexander]

Comment on attachment 552504 [details] [diff] [review]
v1

Review of attachment 552504 [details] [diff] [review]:
-----------------------------------------------------------------

::: buglist.cgi
@@ +767,5 @@
>  # which speeds up quite a few searches where people are really only looking
>  # for the top results.
> +if ($format->{'extension'} eq 'html'
> +    && !defined $cgi->param('limit')
> +    && !defined $params->param('limit'))

Oh gee! Shouldn't we just leave out the $cgi check entirely here?

Comment 2

[Tiago Mello [:timello]]

(In reply to Max Kanat-Alexander from comment #1)
> Comment on attachment 552504 [details] [diff] [review]
> v1
> 
> Review of attachment 552504 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> ::: buglist.cgi
> @@ +767,5 @@
> >  # which speeds up quite a few searches where people are really only looking
> >  # for the top results.
> > +if ($format->{'extension'} eq 'html'
> > +    && !defined $cgi->param('limit')
> > +    && !defined $params->param('limit'))
> 
> Oh gee! Shouldn't we just leave out the $cgi check entirely here?

Indeed.

Comment 3

[Tiago Mello [:timello]]

Attachment: v2

Comment 4

[Tiago Mello [:timello]]

Committing to: bzr+ssh://[e-mail]/bugzilla/trunk/
modified buglist.cgi
Committed revision 7932.

Committing to: bzr+ssh://[e-mail]/bugzilla/4.2/
modified buglist.cgi
Committed revision 7907.