In the new model, a final release like 5.0 should have both a beta and a release report for TCBS and graphs, but currently I get only one "5.0" entry in the version selection on stage. We need some way to get to the two different reports there.
Can we retroactively extend our sql changes backwards to include this?
We can invent some label there for the "final release on beta" entry, like for example "5.0 (beta)" or something, as long as there's a way for us as users to know what it means.
OK. Josh wrote a new stored procedure to try and find these in the data. It's deployed on staging. There's a lot of junk data, so there will likely be a few crashes aggregated that don't fit into the right bucket. You will now see these showing up in the UI (as 6.0 (beta), 5.0 (beta), but the links are busted. Will take a look at those next.
Over to Brandon to fix the UI. If you're not using the version_string to retrieve these, then make sure you match on: - product - version AND - release channel.
Created attachment 552667 [details] [diff] [review] Patch for the UI This patch fixes the 404 by correcting the regular expression that determines the proper URL. The rest of the data loads properly but the graphs are returning a 404.
Chris, there is a patch to fix the URL issues in the bug. However, the middleware is returning an error on all requests for this, probably because "6.0 (beta)" is a string it can't understand. Here is the traceback: Traceback (most recent call last): File "/usr/lib/python2.6/site-packages/web.py-0.33-py2.6.egg/web/application.py", line 242, in process return self.handle() File "/usr/lib/python2.6/site-packages/web.py-0.33-py2.6.egg/web/application.py", line 233, in handle return self._delegate(fn, self.fvars, args) File "/usr/lib/python2.6/site-packages/web.py-0.33-py2.6.egg/web/application.py", line 396, in _delegate return handle_class(f) File "/usr/lib/python2.6/site-packages/web.py-0.33-py2.6.egg/web/application.py", line 387, in handle_class return tocall(*args) File "/home/bsavage/trunk/socorro/webapi/webapiService.py", line 60, in GET raise Exception(stringLogger.getMessages()) Exception: ERROR Caught Error: <type 'exceptions.KeyError'> ERROR ('Firefox', '6.0+(beta)') ERROR trace back follows: ERROR Traceback (most recent call last): ERROR File "/home/bsavage/trunk/socorro/webapi/webapiService.py", line 46, in GET result = self.get(*args) ERROR File "/home/bsavage/trunk/socorro/services/topCrashBySignatureTrends.py", line 86, in get return impl[table_type].twoPeriodTopCrasherComparison(cursor, parameters) ERROR File "/home/bsavage/trunk/socorro/services/tcbs/classic.py", line 198, in twoPeriodTopCrasherComparison context.version) ERROR File "/home/bsavage/trunk/socorro/lib/productVersionCache.py", line 47, in getId raise KeyError((product, version)) ERROR KeyError: ('Firefox', '6.0+(beta)') When you resolve this, please combine it with my patch so that there is only one patch for this bug.
Assignee: bsavage → chris.lonnen
The space in the name is getting encoded, and decoding is a bit of a headache. It seems much simpler to prohibit the space in the version name. Is that possible?
Josh: so basically instead of calling these "6.0 (beta)" we should call them "6.0(beta)" (no space). Actions are therefore: 1. modify the stored proc 2. rerun the backfill Then you can kick this back over to lonnen for testing.
Actually, eliminating the space is a lot easier than that. breakpad=# update product_versions set version_string = '5.0(beta)' where version_string = '5.0 (beta)'; UPDATE 2 breakpad=# update product_versions set version_string = '6.0(beta)' where version_string = '6.0 (beta)'; UPDATE 2 Done. Fixing the SP and checking it in now.
Checked in. I'm done, back to brandon/lonnen.
Backed out please.
(In reply to Laura Thomson :laura from comment #12) > Backed out please. With or without this patch, it still doesn't work.
Chris can you take a look? If not please kick it over to rhelmer or myself.
Created attachment 552884 [details] [diff] [review] Correct patch for the webui This is the correct patch for the UI bug that we're seeing here. For some reason, the wrong patch was uploaded and this was not previously caught.
Comment on attachment 552884 [details] [diff] [review] Correct patch for the webui Yes this fixes the 404 on my dev instance
Attachment #552884 - Flags: review?(rhelmer) → review+
Applying the correct patch, along with Josh's changes to remove the space, solve this bug.
Assignee: chris.lonnen → bsavage
Status: NEW → RESOLVED
Last Resolved: 7 years ago
Resolution: --- → FIXED
QA verified: https://crash-stats.allizom.org/products/Firefox/versions/5.0%28beta%29 https://crash-stats.allizom.org/products/Firefox/versions/5.0.1 https://crash-stats.allizom.org/products/Firefox/versions/5.0b6 https://crash-stats.allizom.org/products/Firefox/versions/6.0 https://crash-stats.allizom.org/products/Firefox/versions/6.0%28beta%29
Component: Socorro → General
Product: Webtools → Socorro
You need to log in before you can comment on or make changes to this bug.