Test for bug 613433 causes browser to navigate BACK unexpected, losing test results

RESOLVED FIXED in mozilla9

Status

()

Core
Selection
RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: jgriffin, Assigned: jgriffin)

Tracking

Trunk
mozilla9
All
Windows 7
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

6 years ago
The test for bug 613433, part of /tests/layout/base/tests/test_reftests_with_caret.html, uses this code:

        sendKey("X", window);
        sendKey("BACK_SPACE", window);

This backspace is being caught by the browser, resulting in a BACK navigation, which loads the previous test in the current test's context.  This causes all the test results for the current test to be lost, and in fact has caused some test failures to be hidden in TBPL.  See bug 677964.

If you apply some setTimeouts to the test, you can also see that the "X" is not appearing in the contenteditable div this test is targeting.
(Assignee)

Comment 1

6 years ago
Ehsan, since this is your test, can you take a look at it when you have a chance?
(In reply to comment #1)
> Ehsan, since this is your test, can you take a look at it when you have a
> chance?

Yes, I know what's happening.  The backspace key is being captured by the chrome event handler and it's causing a back navigation event.  I think this happens because the event is not properly targeted at the contentEditable div.   Can you try giving an ID to the div and then passing that ID to sendKey to make it dispatch the event to the div directly?
(Assignee)

Comment 3

6 years ago
Created attachment 553245 [details] [diff] [review]
mochitest patch

Thanks Ehsan, this patch fixes the problem as you suggested.
Attachment #553245 - Flags: review?(ehsan)
Attachment #553245 - Flags: review?(ehsan) → review+
(Assignee)

Comment 4

6 years ago
Pushed as http://hg.mozilla.org/mozilla-central/rev/700eb783676a
Status: NEW → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
Backed out as http://hg.mozilla.org/mozilla-central/rev/8b970cb862f2

Confusing as all get out, but:

Luke's push Tuesday morning had failures in two reftests_with_caret, bug240933-1.html and bug612271-2.html, on Win7, which I misstarred as being the timeout bug, bug 665408.

The next two pushes had no Win M4 failures.

Your push of this got no Win7 opt tests, because it took so many tries to do the build that the tests got coalesced upward. It had two Win7 debug runs, because for some unfathomable reason I called the first one an upload timeout and retriggered it, maybe from looking before the log was finished uploading, since now it's clearly a failure of five reftests_with_caret. The retriggered run, I finally realized that a failure is not a timeout, and filed bug 679924 on a pair of reftest_with_caret failures.

The next push was for bug 679320, touching editor, so when it failed on Win7 opt, failed on WinXP opt, and failed twice on Win7 debug, I backed it out.

Then my backout failed on Win7 opt and Win7 debug, and I came looking at you ;)
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
(Assignee)

Comment 6

6 years ago
discussed this with philor; what really happened is that this fix revealed some long-standing failures in this test case which were previously hidden (for as long as 9 months); will have to follow up on those individual errors separately.
(Assignee)

Updated

6 years ago
Duplicate of this bug: 669274
(Assignee)

Updated

6 years ago
Depends on: 680164
(Assignee)

Comment 8

6 years ago
Landed again as http://hg.mozilla.org/mozilla-central/rev/1720b28e3115
I backed out this from inbound (will be merged to central once verified it helps), since the increase of M4 failures on Windows was exponential, we have not seen a single green M4 from this push neither on central or inbound (25 oranges out of 25 changesets).

I understand these are real failures and must not be funny to deal with them, but the most frequent failures should be fixed before pushing this again.  This should at least show some green M4 on try before hitting central.
the backout has been merged to central
http://hg.mozilla.org/mozilla-central/rev/4b8e0357f28c

Updated

6 years ago
Assignee: nobody → jgriffin
OK, does http://tbpl.allizom.org/?tree=Try&usebuildbot=1&rev=861ee717f60b look green enough?
(Assignee)

Comment 12

6 years ago
(In reply to Phil Ringnalda (:philor) from comment #11)
> OK, does http://tbpl.allizom.org/?tree=Try&usebuildbot=1&rev=861ee717f60b
> look green enough?

Looks great!
Once more unto the breach, http://hg.mozilla.org/integration/mozilla-inbound/rev/6385d30812f3
Whiteboard: [inbound]
http://hg.mozilla.org/mozilla-central/rev/6385d30812f3
Status: REOPENED → RESOLVED
Last Resolved: 6 years ago6 years ago
Resolution: --- → FIXED
Whiteboard: [inbound]
Target Milestone: --- → mozilla9
You need to log in before you can comment on or make changes to this bug.