Last Comment Bug 678573 - GCC 4.6 build warning: "nsSocketTransportService2.cpp:681:12: warning: variable ‘pollError’ set but not used [-Wunused-but-set-variable]"
: GCC 4.6 build warning: "nsSocketTransportService2.cpp:681:12: warning: variab...
Status: RESOLVED FIXED
:
Product: Core
Classification: Components
Component: Networking (show other bugs)
: Trunk
: x86_64 Linux
: -- normal (vote)
: mozilla9
Assigned To: Daniel Holbert [:dholbert]
:
: Patrick McManus [:mcmanus]
Mentors:
Depends on:
Blocks: buildwarning nsIThreadManager
  Show dependency treegraph
 
Reported: 2011-08-12 11:50 PDT by Daniel Holbert [:dholbert]
Modified: 2011-08-17 04:42 PDT (History)
1 user (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
fix: remove variable (1.60 KB, patch)
2011-08-12 11:56 PDT, Daniel Holbert [:dholbert]
jduell.mcbugs: review+
Details | Diff | Splinter Review

Description Daniel Holbert [:dholbert] 2011-08-12 11:50:25 PDT
> nsSocketTransportService2.cpp: In member function ‘nsresult nsSocketTransportService::DoPollIteration(PRBool)’:
> nsSocketTransportService2.cpp:681:12: warning: variable ‘pollError’ set but not used [-Wunused-but-set-variable]

This variable has never been used. It was added in this CVS checkin...
http://bonsai.mozilla.org/cvsview2.cgi?diff_mode=context&whitespace_mode=show&root=/cvsroot&subdir=mozilla/netwerk/base/src&command=DIFF_FRAMESET&file=nsSocketTransportService2.cpp&rev2=1.21&rev1=1.20
...for bug 326273, back in 2006.

I boldly propose that we remove this variable.
Comment 1 Daniel Holbert [:dholbert] 2011-08-12 11:56:36 PDT
Created attachment 552719 [details] [diff] [review]
fix: remove variable
Comment 2 Daniel Holbert [:dholbert] 2011-08-16 09:30:54 PDT
http://hg.mozilla.org/integration/mozilla-inbound/rev/50edc05d6ee8

Note You need to log in before you can comment on or make changes to this bug.