Closed Bug 678573 Opened 9 years ago Closed 9 years ago

GCC 4.6 build warning: "nsSocketTransportService2.cpp:681:12: warning: variable ‘pollError’ set but not used [-Wunused-but-set-variable]"

Categories

(Core :: Networking, defect)

x86_64
Linux
defect
Not set

Tracking

()

RESOLVED FIXED
mozilla9

People

(Reporter: dholbert, Assigned: dholbert)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

> nsSocketTransportService2.cpp: In member function ‘nsresult nsSocketTransportService::DoPollIteration(PRBool)’:
> nsSocketTransportService2.cpp:681:12: warning: variable ‘pollError’ set but not used [-Wunused-but-set-variable]

This variable has never been used. It was added in this CVS checkin...
http://bonsai.mozilla.org/cvsview2.cgi?diff_mode=context&whitespace_mode=show&root=/cvsroot&subdir=mozilla/netwerk/base/src&command=DIFF_FRAMESET&file=nsSocketTransportService2.cpp&rev2=1.21&rev1=1.20
...for bug 326273, back in 2006.

I boldly propose that we remove this variable.
Attachment #552719 - Flags: review?(jduell.mcbugs)
Attachment #552719 - Flags: review?(jduell.mcbugs) → review+
http://hg.mozilla.org/integration/mozilla-inbound/rev/50edc05d6ee8
Assignee: nobody → dholbert
Blocks: buildwarning
Status: NEW → ASSIGNED
Whiteboard: [inbound]
http://hg.mozilla.org/mozilla-central/rev/50edc05d6ee8
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Whiteboard: [inbound]
Target Milestone: --- → mozilla9
You need to log in before you can comment on or make changes to this bug.