Closed Bug 678660 Opened 12 years ago Closed 12 years ago

Hide about:newaddon from about:about, because it closes itself

Categories

(Toolkit :: Add-ons Manager, defect)

Product:
Toolkit
Component:
Add-ons Manager
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
VERIFIED FIXED
Milestone:
mozilla8

People

(Reporter: steffen.wilberg, Assigned: steffen.wilberg)

References

Details

Attachments

(1 file, 1 obsolete file)

correct patch
1.28 KB, patch
robert.strong.bugs
: review+
Details | Diff | Splinter Review 
      No description provided.
Attached patch patch (obsolete) — — Splinter Review 

        Attachment #552795 -
        Flags: review?(robert.bugzilla)

    
    

    
  
Comment on attachment 552795 [details] [diff] [review]
patch

>Bug 678660: Hide about:newaddon from about:about, because it closes itself
>
>diff --git a/docshell/base/nsAboutRedirector.cpp b/docshell/base/nsAboutRedirector.cpp

>     { "addons", "chrome://mozapps/content/extensions/extensions.xul",
>-      nsIAboutModule::ALLOW_SCRIPT },
>+      nsIAboutModule::ALLOW_SCRIPT |
>+      nsIAboutModule::HIDE_FROM_ABOUTABOUT },
>     { "newaddon", "chrome://mozapps/content/extensions/newaddon.xul",
>       nsIAboutModule::ALLOW_SCRIPT },

This appears to be hiding about:addons; I think you wanted the entry below it for about:newaddon.

    
    

    
  
Comment on attachment 552795 [details] [diff] [review]
patch

What Dave Garret said. :)

Please ask Mossop for review on this as well as me and if he is unable to get to it I will.

        Attachment #552795 -
        Flags: review?(robert.bugzilla) → review-

    
    

    
  

      
      
      
      

        Attached patch
          
          
        correct patch
        — 
          — Splinter Review
      

    


  

        Attachment #552795 -
        Attachment is obsolete: true

        Attachment #552846 -
        Flags: review?(dtownsend)

    
    

    
  
Comment on attachment 552846 [details] [diff] [review]
correct patch

WTF, I shouldn't post patches at 2am, right before going to bed...
This is built and tested by looking at about:about.

        Attachment #552846 -
        Flags: review?(robert.bugzilla)

        Attachment #552846 -
        Flags: review?(robert.bugzilla)

        Attachment #552846 -
        Flags: review?(dtownsend)

        Attachment #552846 -
        Flags: review+

    
    

    
  
http://hg.mozilla.org/mozilla-central/rev/40007fc40e96
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Whiteboard: [inbound]
Target Milestone: --- → mozilla8

    
    

    
  
Verified fixed with Mozilla/5.0 (Macintosh; Intel Mac OS X 10.6; rv:8.0a2) Gecko/20110824 Firefox/8.0a2

I don't think it's worth a manual test. I will leave it open to you Dave to decide for an automated test.
Status: RESOLVED → VERIFIED
Flags: in-testsuite?
Flags: in-litmus-
Flags: in-testsuite? → in-testsuite-

          You need to log in
          before you can comment on or make changes to this bug.