678692 - cfx test does not correctly run on Nightly (8.0a1)

Status: RESOLVED INVALID

(Add-on SDK Graveyard :: General, defect)

Description

[Shane Tomlinson [:stomlinson]]

I am unable to run unit tests using Nightly as the binary.

(addon-sdk)shane@Rowlf ~/development/addon-sdk/packages/api-utils $ cfx test -b /Applications/Nightly.app/Contents/MacOS/firefox
Using binary at '/Applications/Nightly.app/Contents/MacOS/firefox'.
Using profile at '/var/folders/o4/o4UgyngmFheHDwSLc1LaoE+++TI/-Tmp-/tmpoVIeMJ.mozrunner'.
Running tests on Firefox 8.0a1/Gecko 8.0a1 ({ec8030f7-c20a-464f-9b0e-13a3a9e97384}) under Darwin/x86_64-gcc3.
Traceback (most recent call last):
  File "resource://api-utils-api-utils-lib/unit-test-finder.js", line 79, in findTests
    function(dir) {
  File "resource://api-utils-api-utils-lib/unit-test-finder.js", line 85, in 
    function(suite) {
  File "resource://api-utils-api-utils-lib/unit-test-finder.js", line 88, in 
    for (name in module) {
ReferenceError: assignment to undeclared variable name
No tests were run
FAIL
Total time: 1.812416 seconds
Program terminated unsuccessfully.

Comment 1

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

Hi Shane.

You wouldn't happen to know offhand in which Nightly build this stopped working, would you? Does it work in Aurora?

If you don't, I can try testing over the weekend against some older builds to see if I can find the regression date.

Hourly/nightly OSXx64 builds for the past month are here, if you want to give it a try yourself: http://ftp.mozilla.org/pub/mozilla.org/firefox/tinderbox-builds/mozilla-central-macosx64/

Comment 2

[Myk Melez [:myk] [@mykmelez]]

We'd need a bit more info to diagnose this bug.

SDK 1.0 doesn't pass all tests against Firefox nightly builds because of some incompatible changes that landed on mozilla-central several weeks ago.  But we aren't targeting SDK 1.0 at Firefox nightly, so that's ok.

SDK 1.1 test builds, of which the latest is 1.1b1 <https://ftp.mozilla.org/pub/mozilla.org/labs/jetpack/addon-sdk-1.1b1.tar.gz>, are also not targeted at Firefox nightly, but they are targeted at Firefox 7 beta builds, of which the latest is Firefox 7.0b1 <http://www.mozilla.com/en-US/firefox/channel/>.

SDK 1.2 checkouts (i.e. the "master" branch of the SDK repository) are intended to support Firefox builds from both mozilla-central and mozilla-aurora, thus they should pass all tests against Firefox nightly.

Shane: which version of the SDK are you using?

Comment 3

[Shane Tomlinson [:stomlinson]]

I've been out the last few days, sorry for the delay.  I am pulling from the master branch of the GitHub repo, I am assuming that is 1.0 since it is the "stable" version?

Comment 4

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

(In reply to Shane Tomlinson from comment #3)
> I've been out the last few days, sorry for the delay.  I am pulling from the
> master branch of the GitHub repo, I am assuming that is 1.0 since it is the
> "stable" version?

'Master' is currently what will become SDK 1.2.
'Stabilization' will ship as 1.1.

Comment 5

[Shane Tomlinson [:stomlinson]]

I can verify this was user error on my part - I was using an old version of the SDK had not been updated.  Tests run in both 8.0a2 and 9.0a1.

Comment 6

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

Closing this out, given comment 5.

Myk, please reopen if you feel we need to investigate the failures with whatever SDK version Shane was using. :)