678712 - visit count incorrectly determined for redirectsMode=2 queries

Status: RESOLVED INVALID

(Toolkit :: Places, defect)

Description

[al_9x]

https://groups.google.com/group/mozilla.dev.apps.firefox/browse_thread/thread/69c139ecfcaf4370

In Fx6, in a scenario where page A usually but not always redirects to page B, A's redirected visits still count towards A for sorting.  Which means that if A redirects to B a 1000 times, it will not even be a candidate for "most visited," which is expected, but as soon as it fails to redirect just once, it will suddenly appear and be ahead of B.  For a page to magically become first,  out of nowhere, is confusing and counter-intuitive.

redirectsMode=2 means the "redirected-from pages" should be excluded, but since the notion of redirection applies to visits not pages, what it really means is redirected-from visits should be excluded.

In the above scenario A's visit count for sorting purposes should be 1 not 1001.

Comment 1

[Marco Bonardo [:mak] (Away Apr 25 - May 5)]

I suppose doing it correctly would be an high perf hog, btw confirming since it may make sense

Comment 2

[Marco Bonardo [:mak] (Away Apr 25 - May 5)]

redirectsMode has gone