The default bug view has changed. See this FAQ.

Add-on selection UI footer won't look good on non-aero themes

VERIFIED FIXED in Firefox 8

Status

()

Toolkit
Add-ons Manager
VERIFIED FIXED
6 years ago
6 years ago

People

(Reporter: mossop, Assigned: Unfocused)

Tracking

Trunk
mozilla9
All
Windows XP
Points:
---
Bug Flags:
in-testsuite -
in-litmus -

Firefox Tracking Flags

(firefox8 fixed)

Details

(Whiteboard: [qa-])

Attachments

(4 attachments, 1 obsolete attachment)

(Reporter)

Description

6 years ago
From bug 596343 comment 173:

> >+++ b/toolkit/themes/winstripe/mozapps/extensions/selectAddons.css
> >+#footer {
> >+  padding: 15px 12px;
> >+  background-color: #f1f5fb;
> >+  box-shadow: 0px 1px 2px rgb(204,214,234) inset;
> >+}
> >+
> >+.progress-label,
> >+#footer-label {
> >+  font-style: italic;
> >+  color: GrayText;
> >+}
> 
> This is entirely broken. The footer styling won't fit non-aero themes such
> as any theme on Windows XP and the label is guaranteed to be invisible with 
> dark (e.g. high-contrast) themes, where GrayText isn't gray. Please file a
> bug on fixing this?
(Reporter)

Updated

6 years ago
tracking-firefox8: --- → ?
(Reporter)

Updated

6 years ago
Assignee: nobody → bmcbride
Created attachment 553349 [details] [diff] [review]
Patch v1

Turned out to be not a huge issue. Footer looked a little out of place, but not terribly so. And things were still actually readable on high-contrast themes, although I bet some dark themes made it impossible to read. Still, some tweaks seem to help make it look better.
Attachment #553349 - Flags: review?(dtownsend)
(Reporter)

Updated

6 years ago
Attachment #553349 - Flags: review?(dtownsend) → review?(dao)
Status: NEW → ASSIGNED
(In reply to Blair McBride (:Unfocused) from comment #1)
> And things were still actually readable on high-contrast themes,

For you or for those people who would select a high-contrast theme? ;-)
Comment on attachment 553349 [details] [diff] [review]
Patch v1

> #footer {
>   padding: 15px 12px;
>-  background-color: #f1f5fb;
>-  box-shadow: 0px 1px 2px rgb(204,214,234) inset;
> }

What background color will this fall back to? White (e.g. window) or gray (e.g. -moz-dialog)?

> .progress-label,
> #footer-label {
>   font-style: italic;
>-  color: GrayText;
> }

Why are you removing this? GrayText is okay, as long as you're not mixing it with a hardcoded background.

>+@media all and (-moz-windows-compositor) {
>+  #footer {
>+    background-color: #f1f5fb;
>+    box-shadow: 0px 1px 2px rgb(204,214,234) inset;
>+  }
>+
>+  .progress-label,
>+  #footer-label {
>+    color: #6D6D6D;
>+  }
>+}

Are you sure you want -moz-windows-compositor? What's the expected look for aero basic?
Also, could you add selectAddons-aero.css?

Updated

6 years ago
Attachment #553349 - Flags: review?(dao)
(In reply to Dão Gottwald [:dao] from comment #3)
> What background color will this fall back to? White (e.g. window) or gray
> (e.g. -moz-dialog)?

-moz-dialog (ie, gray), so it still looks like a footer. The background grey and GrayText are different enough for the text to be readable, although I'm on the fence over whether the text should just be black to help with legibility (which was why I originally removed GrayText in the first patch).

> Are you sure you want -moz-windows-compositor? What's the expected look for
> aero basic?

I had a closer look at some of the windows/dialogs in Window 7 under Aero Basic, and they use the blue footer style. So made Aero Basic here get the styled footer too.
Created attachment 555017 [details] [diff] [review]
[checked-in] Patch v2
Attachment #553349 - Attachment is obsolete: true
Attachment #555017 - Flags: review?(dao)
Created attachment 555018 [details]
Windows 7 Aero Basic
Created attachment 555019 [details]
Windows 7 Classic
Created attachment 555020 [details]
Windows XP
Comment on attachment 555017 [details] [diff] [review]
[checked-in] Patch v2

> .progress-label,
> #footer-label {
>   font-style: italic;
>   color: GrayText;
> }

I think you should add %ifdef WINSTRIPE_AERO around font-style:italic, as this seems non-native on XP.
Attachment #555017 - Flags: review?(dao) → review+
Done.

http://hg.mozilla.org/integration/fx-team/rev/cd8f12dc6dce
Flags: in-testsuite-
Flags: in-litmus-
Whiteboard: [fixed-in-fx-team]
Comment on attachment 555017 [details] [diff] [review]
[checked-in] Patch v2

http://hg.mozilla.org/mozilla-central/rev/cd8f12dc6dce
Attachment #555017 - Attachment description: Patch v2 → [checked-in] Patch v2
Status: ASSIGNED → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED

Updated

6 years ago
Target Milestone: --- → mozilla9

Updated

6 years ago
Whiteboard: [fixed-in-fx-team]

Updated

6 years ago
Attachment #555017 - Flags: approval-mozilla-aurora?

Updated

6 years ago
Attachment #555017 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
http://hg.mozilla.org/releases/mozilla-aurora/rev/6604a5a31e33
status-firefox8: --- → fixed
tracking-firefox8: ? → ---
Whiteboard: [qa-]
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.