Closed Bug 678768 Opened 8 years ago Closed 8 years ago

GCC build warning about nsFontFace constructor init list order

Categories

(Core :: Layout: Text and Fonts, defect)

Product:
Core
Component:
Layout: Text and Fonts
Type:
defect
Priority:
Not set

Tracking

()

Status:
RESOLVED FIXED

People

(Reporter: dholbert, Unassigned)

References

(Blocks 1 open bug)

Details

(Whiteboard: [build_warning])

Attachments

(1 file)

fix
865 bytes, patch
jfkthame
: review+
Details | Diff | Splinter Review 
GCC build warning:
{
nsFontFace.h: In constructor ‘nsFontFace::nsFontFace(gfxFontEntry*, PRUint8, nsCSSFontFaceRule*)’:
nsFontFace.h:66:11: warning: ‘nsFontFace::mMatchType’ will be initialized after [-Wreorder]
nsFontFace.h:65:31: warning:   ‘nsRefPtr<nsCSSFontFaceRule> nsFontFace::mRule’ [-Wreorder]
nsFontFace.cpp:45:1: warning:   when initialized here [-Wreorder]
}
Attached patch fix — — Splinter Review
Attachment #552910 - Flags: review?(jfkthame)
Blocks: buildwarning
OS: Linux → All
Hardware: x86_64 → All
Whiteboard: [build_warning]
Attachment #552910 - Flags: review?(jfkthame) → review+
http://hg.mozilla.org/integration/mozilla-inbound/rev/9bcd224e7856
Whiteboard: [build_warning] → [build_warning][inbound]
http://hg.mozilla.org/mozilla-central/rev/9bcd224e7856
Status: NEW → RESOLVED
Closed: 8 years ago
Flags: in-testsuite-
Resolution: --- → FIXED
Whiteboard: [build_warning][inbound] → [build_warning]
You need to log in before you can comment on or make changes to this bug.