678785 - resource leak (not closed directory) in gfx/thebes/gfxFT2FontList.cpp

Status: RESOLVED FIXED

(Core :: Graphics, defect)

Description

[David Volgyes]

User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:5.0) Gecko/20100101 Firefox/5.0
Build ID: 20110622232440

Steps to reproduce:

Cppcheck found a resource leak in gfx/thebes/gfxFT2FontList.cpp
in gfxFT2FontList::FindFonts() method.






Actual results:

First of all, I think it's Android specific, because it is in a section wich begins with #elif defined(ANDROID).

In line #216 there is this:
 DIR *d = opendir("/system/fonts");

But nowhere is closed the directory.


Expected results:

You should close DIR *d, when it is not used anymore.
I have attached a proposed fix.

Comment 1

[David Volgyes]

Attachment: My proposed fix.

Comment 2

[Tobias (:Tobbi) Markus]

Setting status to NEW

Comment 3

[John Daggett (:jtd)]

I think you want to include a null check there, i.e.

  if (d) {
    closedir(d);
  }

Comment 4

[David Volgyes]

(In reply to John Daggett (:jtd) from comment #3)
> I think you want to include a null check there, i.e.
> 
>   if (d) {
>     closedir(d);
>   }

Definitely. Thanks.

Comment 5

[John Daggett (:jtd)]

David, could you post a revised patch so I can review+ it?

Comment 6

[Ed Morley [:emorley]]

Unassigning from David per his request (bug 679610 comment 4).

For anyone looking at this bug, feel free to request it be assigned to you, David has very kindly provided a patch, but will not have time to follow it through.

Comment 7

[Atul Aggarwal]

Attachment: Updated Patch

Updated the patch

Comment 8

[Marco Castelluccio [:marco]]

Checkin?

Comment 9

[(no longer active)]

http://hg.mozilla.org/mozilla-central/rev/120aedf2c84f