Proposal: Replace (Empty Signature) with useful strings

RESOLVED FIXED in 2.3.2

Status

Socorro
General
RESOLVED FIXED
7 years ago
6 years ago

People

(Reporter: jberkus, Assigned: lars)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

(Reporter)

Description

7 years ago
Currently we store the following in reports.signature:

NULL == stackwalker crashed while trying to find signature
'' == stackwalker could not determine the crashing thread

Both appear in the UI as (Empty Signature) which is uninformative.  Also, using the values '' and NULL result in a number of persistent and hard-to-resolve bugs in the UI and matviews.

I suggest that we should replace these two with more useful strings which indicate what data we actually have, namely:

"EMPTY SIGNATURE: MDSW FAILED"
and
"EMPTY SIGNATURE: MDSW CRASHING THREAD INDETERMINATE"

These strings would both be more informative, and would eliminate a host of persistent query problems.  It could be easily backfilled in Postgres back to 4/17.

It is unclear on whether we should backfill any data to clean the above up in Hbase and ES.

Comment 1

7 years ago
(In reply to Josh Berkus from comment #0)
> "EMPTY SIGNATURE: MDSW FAILED"
> and
> "EMPTY SIGNATURE: MDSW CRASHING THREAD INDETERMINATE"

Those are still UI-unfriendly but maybe we can find something nice to show there.
(Reporter)

Comment 2

7 years ago
KaiRo,

Any string you want to use is OK with me, as long as it's not '' or NULL.  It's those which we have to write a lot of code to work around.
OS: Linux → All
Hardware: x86 → All
Target Milestone: 2.3 → 2.3.1

Updated

6 years ago
Target Milestone: 2.3.1 → 2.3.2

Updated

6 years ago
Assignee: nobody → lars
Target Milestone: 2.3.2 → ---
(Assignee)

Comment 3

6 years ago
I need more information.  Precisely what do you want the "empty" and "null" signatures to be?

Comment 4

6 years ago
(In reply to K Lars Lohn [:lars] [:klohn] from comment #3)
> I need more information.  Precisely what do you want the "empty" and "null"
> signatures to be?

As long as they are understandable and different cases can be told apart, I don't care too much what exactly they are.

Possible examples:

EMPTY: zero-size minidump
EMPTY: stackwalking failed
EMPTY: no crashing thread determined
(Assignee)

Updated

6 years ago
Target Milestone: --- → 2.3.2
(Assignee)

Comment 5

6 years ago
This change awaits deployment to staging and the push to production.

I used these empty signature replacements:

EMPTY: no crashing thread identified
EMPTY: no frame data available

in either case, if the stackwalker fails, "; corrupt dump" is appended, too.
Status: NEW → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED

Comment 6

6 years ago
Commit pushed to https://github.com/mozilla/socorro

https://github.com/mozilla/socorro/commit/3ef41152d4146ca006e98c65608290cf4318f338
Merge pull request #111 from twobraids/Bug678865

Bug 678865 - eliminate empty signature
(Reporter)

Comment 7

6 years ago
On IRC, Kairo decided that we should not attempt to backfill empty strings.
Component: Socorro → General
Product: Webtools → Socorro
You need to log in before you can comment on or make changes to this bug.