If you think a bug might affect users in the 57 release, please set the correct tracking and status flags for Release Management.

pymake native commands eat exception backtraces

RESOLVED FIXED

Status

()

Core
Build Config
RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: khuey, Assigned: khuey)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

Created attachment 553032 [details] [diff] [review]
Patch

With a slightly modified pycmd.py in the test suite

$ python ../make.py -f native-pycommandpath.mk
make.py[0]: Entering directory 'c:\dev\pymake\tests'
c:\dev\pymake\tests\native-pycommandpath.mk:11:0$ pycmd writetofile results some
 data
ohai
Traceback (most recent call last):
  File "c:\dev\pymake\pymake\process.py", line 196, in run
    m.__dict__[self.method](self.argv)
  File "pycmd.py", line 12, in writetofile
    foo()
  File "pycmd.py", line 7, in foo
    bar()
  File "pycmd.py", line 4, in bar
    raise Exception("ohai")
Exception: ohai
None
c:\dev\pymake\tests\native-pycommandpath.mk:11:0: command 'pycmd writetofile res
ults some data' failed, return code -127
Attachment #553032 - Flags: review?(ted.mielczarek)
Attachment #553032 - Flags: review?(ted.mielczarek) → review+
http://hg.mozilla.org/users/bsmedberg_mozilla.com/pymake/rev/b61d00704344
Status: ASSIGNED → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.