678892 - Add-on owners can add reviews if there are no prior reviews.

Status: VERIFIED FIXED

(addons.mozilla.org Graveyard :: Public Pages, defect)

Description

[krupa raj[:krupa]]

steps to reproduce:
1. Pick an add-on where a) you are the owner b) there are no user reviews.
2. Notice the 'Reviews' section

expected behavior:
Add-on owner is not allowed to add reviews

actual behavior:
If the add-on has no prior reviews, there is a link for the add-on owner to add reviews. See https://addons.allizom.org/en-US/firefox/addon/amazona1/

Comment 1

[Potch [:potch]]

https://github.com/jbalogh/zamboni/commit/d0b0441

Comment 2

[krupa raj[:krupa]]

STR:
1. Tester is not logged in.
2. Load the detail page for one of your add-ons.
3. Click on 'Be the first!' link
4. Log in
5. Add a comment

expected behavior:
Add-on owners cannot add reviews to their own add-ons

actual behavior:
Add-on owners can add reviews to their add-ons.

Comment 3

[Christopher Van Wiemeersch [:cvan]]

this should be fixed by https://github.com/jbalogh/zamboni/commit/7720020

can you verify?

Comment 4

[krupa raj[:krupa]]

I was able to add a review to my own add-on. See https://addons-dev.allizom.org/en-US/firefox/addon/sunkjkj/

Comment 5

[Christopher Van Wiemeersch [:cvan]]

https://github.com/jbalogh/zamboni/commit/5fec5af

Comment 6

[krupa raj[:krupa]]

For add-on owners, https://addons-dev.allizom.org/en-US/firefox/addon/canadian-engl/reviews/add loads a blank page. We should be using Andy's blank page(separate issue).