Open
Bug 678934
Opened 13 years ago
Updated 10 years ago
Committer validation hook for m-c
Categories
(Developer Services :: Mercurial: hg.mozilla.org, defect)
Developer Services
Mercurial: hg.mozilla.org
Tracking
(Not tracked)
NEW
People
(Reporter: rnewman, Unassigned)
Details
(Whiteboard: [kanban:engops:https://mozilla.kanbanize.com/ctrl_board/6/1178] )
doublec and I just ran into an issue pushing latest m-c commits to GitHub. GitHub just turned on committer validation. This commit: --- changeset: 74219:d618c3a26cd4 user: Bob Moss <bmoss@mozilla.com date: Wed Aug 10 15:38:01 2011 -0400 summary: bug 665716 - build breaks when building SUTAgent with sdk level 11, follow up for watcher service r=blassey --- has a malformed user: field. hg-git converts that into: --- commit 776970db2713a3b77770f9ee55eb9e912085c5ef Author: Bob Moss <bmoss@mozilla.com <none@none> Date: Wed Aug 10 15:38:01 2011 -0400 bug 665716 - build breaks when building SUTAgent with sdk level 11, follow up for watcher service r=blassey --- which of course is equally invalid. GitHub rejects that commit (unless you ask them to turn off validation). Perhaps it would be a good idea to avoid this kind of thing in future by having a validating hook in m-c, and a specified format? I can't imagine we want arbitrary user strings getting into the repo.
Assignee | ||
Updated•11 years ago
|
Product: mozilla.org → Release Engineering
Assignee | ||
Updated•10 years ago
|
Product: Release Engineering → Developer Services
Updated•10 years ago
|
Whiteboard: [kanban:engops:https://kanbanize.com/ctrl_board/6/219]
Updated•10 years ago
|
Whiteboard: [kanban:engops:https://kanbanize.com/ctrl_board/6/219] → [kanban:engops:https://mozilla.kanbanize.com/ctrl_board/6/1168] [kanban:engops:https://kanbanize.com/ctrl_board/6/219]
Updated•10 years ago
|
Whiteboard: [kanban:engops:https://mozilla.kanbanize.com/ctrl_board/6/1168] [kanban:engops:https://kanbanize.com/ctrl_board/6/219] → [kanban:engops:https://mozilla.kanbanize.com/ctrl_board/6/1175] [kanban:engops:https://kanbanize.com/ctrl_board/6/219]
Updated•10 years ago
|
Whiteboard: [kanban:engops:https://mozilla.kanbanize.com/ctrl_board/6/1175] [kanban:engops:https://kanbanize.com/ctrl_board/6/219] → [kanban:engops:https://mozilla.kanbanize.com/ctrl_board/6/1177] [kanban:engops:https://kanbanize.com/ctrl_board/6/219]
Updated•10 years ago
|
Whiteboard: [kanban:engops:https://mozilla.kanbanize.com/ctrl_board/6/1177] [kanban:engops:https://kanbanize.com/ctrl_board/6/219] → [kanban:engops:https://mozilla.kanbanize.com/ctrl_board/6/1178] [kanban:engops:https://kanbanize.com/ctrl_board/6/219]
Assignee | ||
Updated•10 years ago
|
Whiteboard: [kanban:engops:https://mozilla.kanbanize.com/ctrl_board/6/1178] [kanban:engops:https://kanbanize.com/ctrl_board/6/219] → [kanban:engops:https://mozilla.kanbanize.com/ctrl_board/6/1178]
You need to log in
before you can comment on or make changes to this bug.
Description
•