Committer validation hook for m-c

NEW
Unassigned

Status

Developer Services
Mercurial: hg.mozilla.org
7 years ago
4 years ago

People

(Reporter: rnewman, Unassigned)

Tracking

Details

(Whiteboard: [kanban:engops:https://mozilla.kanbanize.com/ctrl_board/6/1178] )

(Reporter)

Description

7 years ago
doublec and I just ran into an issue pushing latest m-c commits to GitHub.

GitHub just turned on committer validation.

This commit:

---
changeset:   74219:d618c3a26cd4
user:        Bob Moss <bmoss@mozilla.com
date:        Wed Aug 10 15:38:01 2011 -0400
summary:     bug 665716 - build breaks when building SUTAgent with sdk level 11, follow up for watcher service r=blassey
---

has a malformed user: field. hg-git converts that into:

---
commit 776970db2713a3b77770f9ee55eb9e912085c5ef
Author: Bob Moss <bmoss@mozilla.com <none@none>
Date:   Wed Aug 10 15:38:01 2011 -0400

    bug 665716 - build breaks when building SUTAgent with sdk level 11, follow up for watcher service r=blassey
---

which of course is equally invalid. GitHub rejects that commit (unless you ask them to turn off validation).

Perhaps it would be a good idea to avoid this kind of thing in future by having a validating hook in m-c, and a specified format? I can't imagine we want arbitrary user strings getting into the repo.
(Assignee)

Updated

5 years ago
Product: mozilla.org → Release Engineering
(Assignee)

Updated

4 years ago
Product: Release Engineering → Developer Services

Updated

4 years ago
Whiteboard: [kanban:engops:https://kanbanize.com/ctrl_board/6/219]

Updated

4 years ago
Whiteboard: [kanban:engops:https://kanbanize.com/ctrl_board/6/219] → [kanban:engops:https://mozilla.kanbanize.com/ctrl_board/6/1168] [kanban:engops:https://kanbanize.com/ctrl_board/6/219]

Updated

4 years ago
Whiteboard: [kanban:engops:https://mozilla.kanbanize.com/ctrl_board/6/1168] [kanban:engops:https://kanbanize.com/ctrl_board/6/219] → [kanban:engops:https://mozilla.kanbanize.com/ctrl_board/6/1175] [kanban:engops:https://kanbanize.com/ctrl_board/6/219]

Updated

4 years ago
Whiteboard: [kanban:engops:https://mozilla.kanbanize.com/ctrl_board/6/1175] [kanban:engops:https://kanbanize.com/ctrl_board/6/219] → [kanban:engops:https://mozilla.kanbanize.com/ctrl_board/6/1177] [kanban:engops:https://kanbanize.com/ctrl_board/6/219]

Updated

4 years ago
Whiteboard: [kanban:engops:https://mozilla.kanbanize.com/ctrl_board/6/1177] [kanban:engops:https://kanbanize.com/ctrl_board/6/219] → [kanban:engops:https://mozilla.kanbanize.com/ctrl_board/6/1178] [kanban:engops:https://kanbanize.com/ctrl_board/6/219]
(Assignee)

Updated

4 years ago
Whiteboard: [kanban:engops:https://mozilla.kanbanize.com/ctrl_board/6/1178] [kanban:engops:https://kanbanize.com/ctrl_board/6/219] → [kanban:engops:https://mozilla.kanbanize.com/ctrl_board/6/1178]
You need to log in before you can comment on or make changes to this bug.