Closed Bug 678938 Opened 10 years ago Closed 10 years ago

"ABORT: Shouldn't have current interval in startup or postactive states"

Categories

(Core :: SVG, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla9

People

(Reporter: jruderman, Assigned: birtles)

Details

(Keywords: assertion, testcase)

Attachments

(3 files)

###!!! ABORT: Shouldn't have current interval in startup or postactive states: '!mCurrentInterval', file content/smil/nsSMILTimedElement.cpp, line 576
Attached file stack trace
Harmless in opt
Assignee: nobody → birtles
Status: NEW → ASSIGNED
OS: Mac OS X → All
Hardware: x86_64 → All
Attached patch Patch v1aSplinter Review
Proposed patch with testcase

The problem is we were calling Rewind -> ClearIntervals -> ResetCurrentInterval

Inside ResetCurrentInterval, when we unlink the current interval, we can get callbacks that actually set the current interval again, right after we cleared it. That is, there is no guarantee that at the end of a call to ResetCurrentInterval, mCurrentInterval will be nsnull, just that the previously-current interval (if any) will have been cleared. Likewise for ClearIntervals.

However, Rewind was assuming that mCurrentInterval would be nsnull. That was probably valid a while back since when we were setting mElementState to STATE_STARTUP in advance since so long as we're in the startup state we won't bother updating the current interval and mCurrentInterval will stay nsnull. However, when we refactored out ClearIntervals we made it change the state to STATE_POSTACTIVE which meant that assumption no longer held.
(http://hg.mozilla.org/mozilla-central/rev/6dffbe5e1b5f)

For now, I've made it set the state to STATE_STARTUP before clearing the intervals so we'll ignore any attempts to update the current interval from that point on.
Attachment #557068 - Flags: review?(dholbert)
By the way, I reshuffled a couple of lines in content/smil/crashtests/crashtests.list because the numbering got out of sequence somehow. I just thought I'd fix it while I was already touching that file.
Attachment #557068 - Flags: review?(dholbert) → review+
http://hg.mozilla.org/mozilla-central/rev/b6608d4de5f7
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Whiteboard: [inbound]
Target Milestone: --- → mozilla9
Flags: in-testsuite+
You need to log in before you can comment on or make changes to this bug.