678980 - Source Editor should automatically append closing characters

Status: RESOLVED FIXED

(DevTools :: Source Editor, enhancement, P4)

Description

[Cedric Vivier [:cedricv]]

Auto-closing pairs should probably be defined by the mode (JS, CSS, ...)

For both JS and CSS though following should work :
"{" + "}"
"[" + "]"
"(" + ")"
"/*" + "*/"


There should probably be a pref to disable it.

Comment 1

[Mihai Sucan [:msucan]]

This is *probably* going to be upstreamed to Orion.

Comment 2

[Kevin Dangoor]

This should definitely be handled by Orion. I'll also note that this is low priority.

Comment 3

[Cedric Vivier [:cedricv]]

(In reply to Kevin Dangoor from comment #2)
> This should definitely be handled by Orion. I'll also note that this is low
> priority.

Low priority but also low hanging fruit?
This is reasonably simple to implement (at least initially on textarea implementation and/or SourceEditor level), and it really improves *a lot* Style Editor's UX (flicker becomes more an exception than a rule)

Comment 4

[Cedric Vivier [:cedricv]]

I mean my rationale for opening this bug is not about the 'debatable' comfort given by the future wrt to typing (faster), but a huge change in regard to updating stylesheets real-time with much less flicker in most simple situations (before incremental parser stuff that allow the same experience in all situations AND with this feature preffed off if the user prefers so)

Comment 5

[Mihai Sucan [:msucan]]

This is most-likely going to be implemented upstream in Orion. We should wait for that.

Comment 6

[Rob Campbell [:rc] (:robcee)]

Moving to Source Editor component.

Filter on CHELICERAE.

Comment 7

[Anton Kovalyov (:anton)]

This is implemented now.

Comment 8

[Panos Astithas (he/him) [:past] (please ni?)]

It looks like it is implemented in the style editor, but I don't see it in the scratchpad nor in the shader editor. Do we have separate bugs for these or should this be reopened?

Comment 9

[Anton Kovalyov (:anton)]

There's an option for that, autoCloseBrackets. Other components can enable it the same way StyleSheetEditor.jsm did:

  let editor = new Editor({
    value: "...",
    ...
    autoCloseBrackets: "{}()[]"
  });

Comment 10

[Anton Kovalyov (:anton)]

Also, there's a talk about enabling this addon by default in bug 940713.