679180 - IonMonkey: add infallible method in LIR

Status: RESOLVED INCOMPLETE

(Core :: JavaScript Engine, defect)

Description

[Hannes Verschore [:h4writer]]

During talk in irc with dvander we decided it would be better to have sort of an abstraction for deciding when a bailout should get created.

1) add function "infallible" returning if a bailout is needed
2) adjust LAddI to reflect those changes

Comment 1

[David Anderson [:dvander] - inactive, e-mail if emergency]

I would lean toward "fallible" instead, because usually we'll check:
   if (ins->fallible())

Which looks better than:
   if (!ins->infallible())

Comment 2

[Hannes Verschore [:h4writer]]

Attachment: patch

Implementing adjustements.
Tomorrow I'll post the patch to adjust LUnbox/LDoubleUnbox/... to this.

(In reply to David Anderson [:dvander] from comment #1)
> I would lean toward "fallible" instead, because usually we'll check:
>    if (ins->fallible())
> 
> Which looks better than:
>    if (!ins->infallible())

Did meant fallible, but didn't saw I made infallible of it until after posting.

Comment 3

[Hannes Verschore [:h4writer]]

Attachment: part 2: adjusting LIR's

small nits:
- LAddI(true) instead of LAddI(1)
- Move JS_ASSERT(snapshot) into bailoutIf function

Implement LIR's:
- Unbox*