679279 - Code cleanup, robustness, and strictness improvements

Status: RESOLVED FIXED

(Firefox :: Sync, defect)

Description

[Richard Newman [:rnewman]]

Here shall accrue our latest batch of minor Sync improvements.

Comment 1

[Richard Newman [:rnewman]]

Attachment: Part 1: minor improvements to engines code. v1

Comment 2

[Richard Newman [:rnewman]]

Attachment: Part 2: add missing 'let' in service.js to avoid strict warning. v1

Comment 3

[Richard Newman [:rnewman]]

Attachment: Part 3: bookmarks engine cleanup. v1

This patch reformats some definitions to more closely follow the style guide
and allow for easier extension in subsequent patches; uses Object.keys instead
of comprehensions; and eliminates the archiveBookmarks helper.

Comment 4

[Richard Newman [:rnewman]]

Comment on attachment 553383 [details] [diff] [review]
Part 1: minor improvements to engines code. v1

Setting one review flag as a reminder.

Comment 5

[Philipp von Weitershausen [:philikon]]

Comment on attachment 553383 [details] [diff] [review]
Part 1: minor improvements to engines code. v1

>     this._modifiedIDs = [id for (id in this._modified)];

This looks good to me, but we should also go through our code and replace all these Array comprehensions with Object.keys(). It is about 6 times faster.

Comment 6

[Philipp von Weitershausen [:philikon]]

Comment on attachment 553384 [details] [diff] [review]
Part 2: add missing 'let' in service.js to avoid strict warning. v1

Yay, but let's fix all of them while we're at it. Yes, all of them.

Comment 7

[Richard Newman [:rnewman]]

Fixed in services:

http://hg.mozilla.org/services/services-central/rev/61eaf2179fef
http://hg.mozilla.org/services/services-central/rev/7e4d90c68351
http://hg.mozilla.org/services/services-central/rev/becba4169e37
http://hg.mozilla.org/services/services-central/rev/dfb016c497ae

Comment 8

[Richard Newman [:rnewman]]

http://hg.mozilla.org/mozilla-central/rev/61eaf2179fef
http://hg.mozilla.org/mozilla-central/rev/7e4d90c68351
http://hg.mozilla.org/mozilla-central/rev/becba4169e37
http://hg.mozilla.org/mozilla-central/rev/dfb016c497ae