Closed Bug 679279 Opened 8 years ago Closed 8 years ago

Code cleanup, robustness, and strictness improvements

Categories

(Firefox :: Sync, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla9

People

(Reporter: rnewman, Assigned: rnewman)

References

Details

(Whiteboard: [qa-][fixed in services])

Attachments

(3 files)

Here shall accrue our latest batch of minor Sync improvements.
Assignee: nobody → rnewman
Status: NEW → ASSIGNED
This patch reformats some definitions to more closely follow the style guide
and allow for easier extension in subsequent patches; uses Object.keys instead
of comprehensions; and eliminates the archiveBookmarks helper.
Comment on attachment 553383 [details] [diff] [review]
Part 1: minor improvements to engines code. v1

Setting one review flag as a reminder.
Attachment #553383 - Flags: review?(philipp)
Comment on attachment 553383 [details] [diff] [review]
Part 1: minor improvements to engines code. v1

>     this._modifiedIDs = [id for (id in this._modified)];

This looks good to me, but we should also go through our code and replace all these Array comprehensions with Object.keys(). It is about 6 times faster.
Attachment #553383 - Flags: review?(philipp) → review+
Comment on attachment 553384 [details] [diff] [review]
Part 2: add missing 'let' in service.js to avoid strict warning. v1

Yay, but let's fix all of them while we're at it. Yes, all of them.
Attachment #553384 - Flags: review+
Component: Firefox Sync: Backend → Sync
Product: Cloud Services → Firefox
You need to log in before you can comment on or make changes to this bug.