Status
People
(Reporter: markh, Unassigned)
Tracking
Details
Attachments
(1 attachment)
If a service call is made and fails, the errbacks are not called with an error object as described in https://developer.mozilla.org/en/OpenWebApps/The_JavaScript_API#Error_Objects. Things are wrong in at least the following cases: * The service invocation raises an exception. * The service invocation calls its errback with string arguments.
|
(Reporter) | |
Comment 1•7 years ago
|
||
Created attachment 553392 [details] Pointer to Github pull request: https://github.com/mozilla/openwebapps/pull/76 Pointer to Github pull-request
|
|
(Reporter) | |
Comment 2•7 years ago
|
||
Comment on attachment 553392 [details] Pointer to Github pull request: https://github.com/mozilla/openwebapps/pull/76 Merged with develop so now applies cleanly.
Attachment #553392 -
Flags: review?(anant)
Attachment #553392 -
Flags: feedback?(mixedpuppy)
|
||
Comment 3•7 years ago
|
||
Comment on attachment 553392 [details] Pointer to Github pull request: https://github.com/mozilla/openwebapps/pull/76 nit: "extra" param in cberrshim is really a 'message', why not just call it that? +1 with a name change
Attachment #553392 -
Flags: feedback?(mixedpuppy) → feedback+
|
||
Comment 4•7 years ago
|
||
Comment on attachment 553392 [details] Pointer to Github pull request: https://github.com/mozilla/openwebapps/pull/76 It looks like we could use cberrshim in other places as well, might make sense to move it to a util library at some point. r+ with mixepuppy's feedback for now.
Attachment #553392 -
Flags: review?(anant) → review+
|
|
(Reporter) | |
Comment 5•7 years ago
|
||
Pushed as rev cf344c6bed06767eb461c7132e4f639400d96abb
Status: NEW → RESOLVED
Last Resolved: 7 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•