679310 - Inconsistent results-count for query for 'RtlpWorkerCallout'

Status: VERIFIED FIXED

(Socorro :: General, task)

Description

[Stephen Donner [:stephend] Not actively reading bugmail]

Attachment: Screenshot showing 430 results for 'RtlpWorkerCallout'

https://crash-stats.allizom.org/query/query?product=Firefox&version=Firefox%3A6.0b5&range_value=1&range_unit=weeks&date=08%2F16%2F2011+02%3A59%3A59&query_search=signature&query_type=contains&query=RtlpWorkerCallout&reason=&build_id=&process_type=any&hang_type=any&do_query=1 yields me 430 results

but clicking through gives me 650:

https://crash-stats.allizom.org/report/list?product=Firefox&version=Firefox%3A6.0b5&query_search=signature&query_type=contains&query=RtlpWorkerCallout&reason_type=contains&date=08%2F16%2F2011%2002%3A59%3A59&range_value=1&range_unit=weeks&hang_type=any&process_type=any&do_query=1&signature=RtlpWorkerCallout

Comment 1

[Stephen Donner [:stephend] Not actively reading bugmail]

Attachment: Screenshot showing 650 results for 'RtlpWorkerCallout', after clicking through...

Comment 2

[Robert Helmer [:rhelmer]]

Attachment: put extra "OR" clause in an else

With this patch, the counts match up to 430 on my dev instance. 

hard to see in UI, I dumped the SQL and did a count(*):
breakpad=> select count(*)
                   FROM   reports JOIN  product_versions ON reports.version = product_versions.release_version AND reports.product = product_versions.product_name LEFT OUTER JOIN  reports_duplicates ON reports.uuid = reports_duplicates.uuid WHERE  reports.signature = 'RtlpWorkerCallout' AND (reports.product = 'Firefox' AND product_versions.version_string = '6.0b5' AND reports.version = product_versions.release_version AND reports.release_channel ILIKE 'beta' AND product_versions.build_type = 'beta' AND EXISTS ( SELECT 1 FROM product_version_builds WHERE product_versions.product_version_id = product_version_builds.product_version_id AND build_numeric(reports.build) = product_version_builds.build_id )) AND reports.signature  LIKE '%RtlpWorkerCallout%' AND reports.date_processed BETWEEN CAST('08/16/2011 02:59:59' AS TIMESTAMP WITHOUT TIME ZONE) - CAST('1 weeks' AS INTERVAL) AND CAST('08/16/2011 02:59:59' AS TIMESTAMP WITHOUT TIME ZONE); count 
-------   
430
(1 row)

Comment 3

[Robert Helmer [:rhelmer]]

Attachment: put extra "OR" clause in an else

Comment 4

[Robert Helmer [:rhelmer]]

Attachment: put extra "OR" clause in an else, get precedence right

OK I've tested this with:
* topcrasher links (off by a little bit, expected)
* old search -> report clickthrough (count matches)
* new beta search -> report clickthrough (count matches)
* new release search -> report clickthrough (count matches)

Doing multi-version search should work too, but the query takes a _very_ long time on stagedb.

Comment 5

[Robert Helmer [:rhelmer]]

Attachment: put extra "OR" clause in an else, get precedence right

Comment 6

[Lonnen :lonnen]

Comment on attachment 553437 [details] [diff] [review]
put extra "OR" clause in an else, get precedence right

Difficult to test because of the database situation, but the code looks good and the errors I encounter are from the db, not this patch.

Comment 7

[Robert Helmer [:rhelmer]]

Landed on trunk:
Committed revision 3461.

Landed on 2.2 branch:
Committed revision 3462.

Comment 8

[Robert Helmer [:rhelmer]]

(In reply to Robert Helmer [:rhelmer] from comment #4)
> Doing multi-version search should work too, but the query takes a _very_
> long time on stagedb.

I take this last part back; I don't think this code has ever been right in this case. I'll file a followup bug specifically about this.

Comment 9

[Matt Brandt [:mbrandt]]

QA verified. Good find stephend. The returned result counts add up correctly now. I verified this with several different products and releases.

Steps to reproduce (comment 0):

https://crash-stats.allizom.org/query/query?product=Firefox&version=Firefox%3A6.0b5&range_value=1&range_unit=weeks&date=08%2F16%2F2011+02%3A59%3A59&query_search=signature&query_type=contains&query=RtlpWorkerCallout&reason=&build_id=&process_type=any&hang_type=any&do_query=1 yields me 430 results

and clicking through gives 430:

https://crash-stats.allizom.org/report/list?product=Firefox&version=Firefox%3A6.0b5&query_search=signature&query_type=contains&query=RtlpWorkerCallout&reason_type=contains&date=08%2F16%2F2011%2002%3A59%3A59&range_value=1&range_unit=weeks&hang_type=any&process_type=any&do_query=1&signature=RtlpWorkerCallout